Date: Thu, 12 Jul 2007 08:59:42 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: Jack F Vogel <jfv@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ixgbe LICENSE ixgbe.c ixgbe.h ixgbe_82598.c ixgbe_api.c ixgbe_api.h ixgbe_common.c ixgbe_common.h ixgbe_osdep.h ixgbe_phy.c ixgbe_phy.h ixgbe_type.h Message-ID: <20070712085707.G68820@fledge.watson.org> In-Reply-To: <200707112303.l6BN3HPu010363@repoman.freebsd.org> References: <200707112303.l6BN3HPu010363@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 11 Jul 2007, Jack F Vogel wrote: > jfv 2007-07-11 23:03:17 UTC > > FreeBSD src repository > > Added files: > sys/dev/ixgbe LICENSE ixgbe.c ixgbe.h ixgbe_82598.c > ixgbe_api.c ixgbe_api.h ixgbe_common.c > ixgbe_common.h ixgbe_osdep.h ixgbe_phy.c > ixgbe_phy.h ixgbe_type.h > Log: > Add the actual source too :) This commit message leaves a lot to be desired, especially for 1.1 revisions. I think you should consider a forced commit that mentions something more than that the files are source code -- perhaps a 2-3 level sentence summary of what the actual change meant. Remember that changes on other files, such as the conf files you touched in the earlier commit, won't appear in "cvs log" of these files. Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070712085707.G68820>