Date: Wed, 29 Jul 2015 18:05:44 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Ermal =?iso-8859-1?Q?Lu=E7i?= <eri@freebsd.org> Cc: Olivier =?iso-8859-1?Q?Cochard-Labb=E9?= <olivier@cochard.me>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285051 - head/sys/netinet Message-ID: <20150729150544.GM97401@FreeBSD.org> In-Reply-To: <CAPBZQG3owDM4y4noEa9S044MPuw89QZnkG6Ne7y94iBERp37Pg@mail.gmail.com> References: <201507021810.t62IAgCc003272@repo.freebsd.org> <20150728124220.GW72729@FreeBSD.org> <CAPBZQG3owDM4y4noEa9S044MPuw89QZnkG6Ne7y94iBERp37Pg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ermal,
On Wed, Jul 29, 2015 at 03:00:59PM +0200, Ermal Luçi wrote:
E> > E> @@ -934,6 +950,7 @@ ip_forward(struct mbuf *m, int srcrt)
E> > E> */
E> > E> if (!srcrt && ia == NULL) {
E> > E> icmp_error(m, ICMP_UNREACH, ICMP_UNREACH_HOST, 0, 0);
E> > E> + RO_RTFREE(&ro);
E> > E> return;
E> > E> }
E> >
E> > Here the ifa reference is leaked upon return.
E> >
E> >
E> Gleb,
E>
E> the improvement on the ifa_ref not needed is something to look at but the
E> ifa_ref here is not lost since ia == NULL, no?
E> Maybe i am missing something else.
Sure you are right. Mea culpa.
E> Also can we put this on a review?
It is possible. Let's just wait for Olivier to return and ask him to
do a benchmark :)
--
Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150729150544.GM97401>