Date: Wed, 09 Jan 2019 18:55:00 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 234413] quotactl() returns wrong error Message-ID: <bug-234413-227-M7uXbVIm51@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-234413-227@https.bugs.freebsd.org/bugzilla/> References: <bug-234413-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234413 --- Comment #6 from Mark Johnston <markj@FreeBSD.org> --- (In reply to Emrion from comment #5) I was wondering specifically which quotactl() operation was returning ENOEN= T.=20 It's a bit more clear now; we have the following in zfs_getquota(): 146 if (quotaobj =3D=3D 0 || zfsvfs->z_replay) {=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 147 error =3D ENOENT;=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 148 goto done;=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20 149 } whereas UFS does: 1302 dqvp =3D ump->um_quotas[type];=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20 1303 if (dqvp =3D=3D NULLVP || (ump->um_qflags[type] & QTF_CLOSING)= ) {=20=20=20=20=20=20 1304 *dqp =3D NODQUOT;=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 1305 UFS_UNLOCK(ump);=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20 1306 return (EINVAL);=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20 1307 } This use of EINVAL isn't documented in the man page. Linux's quotactl() doesn't document it either, but I presume that it always returns EINVAL in = this case. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234413-227-M7uXbVIm51>