Date: Sat, 20 Aug 2022 13:47:05 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: Charlie Li <ml@vishwin.info> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, zi@freebsd.org Subject: Re: git: 1922eb3e9c23 - main - protosw: retire pr_slowtimo and pr_fasttimo Message-ID: <YwFISet3JLhAeUBy@FreeBSD.org> In-Reply-To: <d45c845a-a7cd-f259-27e5-a6775b57a901@vishwin.info> References: <202208171852.27HIqKbY013087@gitrepo.freebsd.org> <d45c845a-a7cd-f259-27e5-a6775b57a901@vishwin.info>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 20, 2022 at 01:35:38PM -0400, Charlie Li wrote: C> > -#define PR_SLOWHZ 2 /* 2 slow timeouts per second */ C> > -#define PR_FASTHZ 5 /* 5 fast timeouts per second */ C> > - C> > /* C> > * This number should be defined again within each protocol family to avoid C> > * confusion. C> > C> > C> This broke net-mgmt/net-snmp, which uses PR_SLOWHZ directly. Upstream C> issue filed at https://github.com/net-snmp/net-snmp/issues/445 Thanks for report! Looking into mibII/tcp.c code, I'm 99% sure it wasn't correct on FreeBSD for at least 10-15 years if not always. The next failure is: mibgroup/ip-mib/data_access/scalars_sysctl.c:285:38: error: use of undeclared identifier 'PR_SLOWHZ' ipReasmTimeout_val = IPFRAGTTL / PR_SLOWHZ; And this code was actually constructing correct value. I created pull requests upstream. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YwFISet3JLhAeUBy>