Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 1 Mar 2024 23:04:39 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: c5246cb7b015 - main - nvme: Report only the unknown bits
Message-ID:  <202403012304.421N4duD039512@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=c5246cb7b0153730101163381576e9b0e91c73a5

commit c5246cb7b0153730101163381576e9b0e91c73a5
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2024-03-01 23:03:19 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2024-03-01 23:04:27 +0000

    nvme: Report only the unknown bits
    
    When we get a smart error that's unknown, report only the unknown
    (reserved) bits of the Critical Warning Bitfield.
    
    Sponsored by:           Netflix
---
 sys/dev/nvme/nvme_ctrlr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c
index b29512455fda..0d33454125bd 100644
--- a/sys/dev/nvme/nvme_ctrlr.c
+++ b/sys/dev/nvme/nvme_ctrlr.c
@@ -650,7 +650,8 @@ nvme_ctrlr_log_critical_warnings(struct nvme_controller *ctrlr,
 
 	if (state & NVME_CRIT_WARN_ST_RESERVED_MASK)
 		nvme_ctrlr_devctl_log(ctrlr, "critical",
-		    "unknown critical warning(s): state = 0x%02x", state);
+		    "unknown critical warning(s): state = 0x%02x",
+		    state & NVME_CRIT_WARN_ST_RESERVED_MASK);
 }
 
 static void



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202403012304.421N4duD039512>