Date: Thu, 27 Nov 2008 10:55:34 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: ivoras@gmail.com Cc: svn-src-head@FreeBSD.org, des@des.no, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r185356 - head/sys/dev/ixgbe Message-ID: <20081127.105534.188222755.imp@bsdimp.com> In-Reply-To: <9bbcef730811270238k61c3e59fqee7715f017d70ccf@mail.gmail.com> References: <9bbcef730811270220h1a7f812k2ba340737132ff82@mail.gmail.com> <8663m94g30.fsf@ds4.des.no> <9bbcef730811270238k61c3e59fqee7715f017d70ccf@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <9bbcef730811270238k61c3e59fqee7715f017d70ccf@mail.gmail.co=
m>
"Ivan Voras" <ivoras@gmail.com> writes:
: 2008/11/27 Dag-Erling Sm=F8rgrav <des@des.no>:
: > "Ivan Voras" <ivoras@gmail.com> writes:
: >> And at least the newer GEOM code also uses c99 variable declaratio=
ns
: >> (not only for initializers - they were c99 from the start).
: >
: > I'm curious about what you mean with "c99 variable declarations". =
If
: > you are referring to loop variable declarations, I can only find tw=
o
: > cases, both in g_linux_lvm.c. Other than that and mixing declarati=
ons
: > with statements (which style(9) explicitly forbids), there is no
: > difference between c89 to c99 as far as variable declarations are
: > concerned.
: =
: Yes, but not only loops - I mean things like:
: =
: if () {
: struct *something abc;
: int y;
: ...
: }
: =
: You'll probably find my code is one the biggest users of this style
: but I've only started using it when I saw it already used.
This is a K&R level C construct.
It is discouraged in style(9) because it makes it hard to find
declarations. However, it is used in the kernel in a number of
places.
I personally really dislike the style (and yes, I know all the
arguments for it). If you really want something that complex inside a
block to need block scoped variables, then that really argues for a
function oft times...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081127.105534.188222755.imp>