Date: Thu, 15 Jan 2009 10:14:50 -0500 From: John Baldwin <jhb@freebsd.org> To: Konstantin Belousov <kib@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186601 - head/sys/kern Message-ID: <200901151014.51241.jhb@freebsd.org> In-Reply-To: <200812301251.mBUCpuUk093863@svn.freebsd.org> References: <200812301251.mBUCpuUk093863@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 30 December 2008 7:51:56 am Konstantin Belousov wrote: > Author: kib > Date: Tue Dec 30 12:51:56 2008 > New Revision: 186601 > URL: http://svn.freebsd.org/changeset/base/186601 > > Log: > Clear the pointers to the file in the struct filedesc before file is > closed in fdfree. Otherwise, sysctl_kern_proc_filedesc may dereference > stale struct file * values. Good catch! This may fix many panics I saw at Yahoo. The fact that this code didn't clear the file pointers to NULL used to bother me, but I could never put my finger on exactly why. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901151014.51241.jhb>