Date: Tue, 23 Oct 2012 20:59:35 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Maxim Sobolev <sobomax@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r241625 - head/usr.sbin/cron/cron Message-ID: <20121023175935.GY35915@deviant.kiev.zoral.com.ua> In-Reply-To: <50856FE9.1020807@FreeBSD.org> References: <201210170044.q9H0iZHo055977@svn.freebsd.org> <20121017174814.GN35915@deviant.kiev.zoral.com.ua> <507F0FF8.3090602@FreeBSD.org> <20121017201811.GO35915@deviant.kiev.zoral.com.ua> <50856FE9.1020807@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Oct 22, 2012 at 09:10:17AM -0700, Maxim Sobolev wrote: > Guys, > > The latest version of the patch against current HEAD is available here: > > http://sobomax.sippysoft.com/cron.diff > > Any comments/suggestions are appreciated. This version should default to > previous behaviour of waking up every 60 seconds unless there is > @every_second entry in the cron. > > Konstantin, can you please put it for testing to your boxes? Please make > sure to do `make clean' after applying it, as libcron is not listed as a > dependency for cron, so it's possible that some changes may not be > picked up. I patched the HEAD with the provided diff, and did make clean all in usr.sbin/cron. The resulting binary correctly handled both /etc/crontab and personal crontabs with the each-minute jobs. I did not read the changed logic. Still, I suggest you to wrap the too-long line in the patch. Also, it seems that the changes would benefit from (extensive) commenting in the code. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlCG2wcACgkQC3+MBN1Mb4i0lACg4XaUp9zqsXjIlrTiiiBrBrQO HjYAnRMK1IZ6FmobeGnHNm878IZ0rsqZ =Pcdk -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121023175935.GY35915>