Date: Tue, 5 Apr 2016 23:37:16 +0200 From: =?utf-8?Q?Martin_Waschb=C3=BCsch?= <martin@waschbuesch.de> To: Michelle Sullivan <michelle@sorbs.net> Cc: Kurt Jaeger <lists@opsec.eu>, ports@freebsd.org Subject: Re: Committer needed for PR 208029 Message-ID: <C96569DA-ADC5-4BE0-819A-7375C3F50D8E@waschbuesch.de> In-Reply-To: <57042958.5010701@sorbs.net> References: <498CA3F8-15EF-45BD-880C-241F83CBE3DD@waschbuesch.de> <20160405185159.GK35640@home.opsec.eu> <20160405200835.GM35640@home.opsec.eu> <57042958.5010701@sorbs.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> Umm probably a really bad idea... consider this or something more =
creative/descriptive:
>=20
> .if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} < 1000000 && =
${WITH_OPENSSL_PORT} !=3D "yes"
> BROKEN=3D You must set WITH_OPENSSL_PORT=3Dyes in =
/etc/make.conf on Pre 10.x
> .endif
>=20
>=20
> ... the idea instead of silently turning it on which could cause a =
myriad of hell for production systems where some ports are compiled =
against security/openssl and some against the base openssl... stop the =
compile and tell the user what they have to do to resolve it... which =
will then make anything else use the same openssl and lessen the =
dependency/library issues that could happen.
Actually, I just noticed (when compiling the port), that the Makefile =
now says:
WITH_OPENSSL_PORT=3Dyes
GNUTLS_CONFIGURE_WITH=3D gnutls
GNUTLS_LIB_DEPENDS=3D libgnutls.so:security/gnutls
POLARSSL_CONFIGURE_WITH=3Dmbedtls
POLARSSL_LIB_DEPENDS=3D libmbedtls.so:security/polarssl13
.include <bsd.port.options.mk>
.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} < 1000000
WITH_OPENSSL_PORT=3Dyes
.endif
Which means that the ports version is used regardless of OSVERSION...
Shall I open a PR for it and incorporate the BROKEN=3D approach?
Martin=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C96569DA-ADC5-4BE0-819A-7375C3F50D8E>