Date: Thu, 14 Feb 2002 10:52:42 -0800 From: Greg Lehey <grog@FreeBSD.org> To: Alfred Perlstein <alfred@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/conf GENERIC Message-ID: <20020214105242.A2226@sydney.worldwide.lemis.com> In-Reply-To: <20020213172335.C63886@elvis.mu.org>; from alfred@FreeBSD.org on Wed, Feb 13, 2002 at 05:23:35PM -0800 References: <200202131847.g1DIlp851160@freefall.freebsd.org> <20020213170750.B732@sydney.worldwide.lemis.com> <20020213172335.C63886@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, 13 February 2002 at 17:23:35 -0800, Alfred Perlstein wrote: > * Greg Lehey <grog@FreeBSD.org> [020213 17:08] wrote: >> On Wednesday, 13 February 2002 at 10:47:51 -0800, Alfred Perlstein wrote: >>> alfred 2002/02/13 10:47:51 PST >>> >>> Modified files: >>> sys/i386/conf GENERIC >>> Log: >>> Re-enable WITNESS for GENERIC. Since the 5.x branch is mostly about >>> SMP we'd like as much feedback as possible from users about possible >>> locking problems as early as possible. >> >> Why did you do that when obviously rwatson disagreed? The correct >> thing to do would have been to get a consensus first and give rwatson >> the opportunity to back it out. Note that we definitely don't have a >> consensus. >> >>> To negate most of the performance impact I've also enabled >>> WITNESS_SKIPSPIN. I've done this as we've been running WITNESS >>> over the spinlock code for a while without incident and it goes a >>> long way to making the performance problems of WITNESS much more >>> bearable. >> >> This might be a good compromise. But we need to agree first. > > This issue has been resolved, the WITNESS_SKIPSPIN stuff seems to have > made people a bit more comfortable about it. That's the technical issue. It doesn't address the issue of backing out other people's commits without consultation. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020214105242.A2226>