Date: Thu, 20 Nov 2008 16:47:18 GMT From: Edward Tomasz Napierala <trasz@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 153265 for review Message-ID: <200811201647.mAKGlImY035793@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=153265 Change 153265 by trasz@trasz_victim7 on 2008/11/20 16:46:26 Tweaked a previous tweak to match new ZFS behaviour wrt ACL inheritance. I'm not sure about this - I have no idea why the Sun guys do it this way - but regression tests coverage is pretty good for this code and they pass, so anyway. Right now ZFS passes all the tests, and UFS fails few of fstest/tests/granular, by returning EACCES instead of EPERM in situations involving DELETE and DELETE_CHILD. Affected files ... .. //depot/projects/soc2008/trasz_nfs4acl/sys/kern/subr_acl_nfs4.c#35 edit Differences ... ==== //depot/projects/soc2008/trasz_nfs4acl/sys/kern/subr_acl_nfs4.c#35 (text+ko) ==== @@ -876,7 +876,6 @@ * apparently does that. */ if (((entry->ae_flags & ACL_ENTRY_LIMIT_INHERIT) || - (entry->ae_flags & ACL_ENTRY_DIRECTORY_INHERIT) == 0 || !is_directory) && entry->ae_extended == ACL_EXTENDED_ALLOW) entry->ae_perm &= ~(ACL_WRITE_ACL | ACL_WRITE_OWNER);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200811201647.mAKGlImY035793>