Date: Thu, 7 Mar 2002 11:42:10 +0100 From: Svein Skogen <tds@dmnshq.net> To: cvs-all@FreeBSD.ORG Cc: "Brian F. Feldman" <green@FreeBSD.ORG> Subject: Re: cvs commit: src/lib/libpam/modules modules.inc src/lib/libpam/modules/pam_alreadyloggedin Makefile pam_alreadyloggedin.8 pam_alreadyloggedin.c Message-ID: <20020307114210.A25376@dmnshq.net> In-Reply-To: <200203070015.g270F4A43670@green.bikeshed.org>; from green@FreeBSD.ORG on Wed, Mar 06, 2002 at 07:15:04PM -0500 References: <mark@grondar.za> <200203070015.g270F4A43670@green.bikeshed.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 06, 2002 at 07:15:04PM -0500, Brian F. Feldman wrote: > Mark Murray <mark@grondar.za> wrote: > > > > Reviewed by: nobody > > > > Approved by: nobody > > > > > > Robert took a look at it, and other people agreed it was a generally > > > interesting module to have. Add to that that it's small, not turned on > > > unless you do it yourself, and doesn't break the build, and I don't see what > > > the problem is adding a new PAM module. > > > > I suspect that the pam_self module should take the responsibility > > for doing what this does, probably with the assistance of some > > appropriate options. > > I'm not sure; I think it's probably worth keeping them logically separate > since they don't perform very similar actions, although they allow a > somewhat similar policy to be implemented. > > > I have a (minor) problem with the name; it's too clumsy. > > Yeah, but I would like to know of a better one (without just moving the > ugliness to the name of the option used ;) Thanks for checking it out! Actually, from an end user point of view, I consider this a good solution to the problems that surfaced when he committed this directly into pam. Not only does this make it a very separate option, but it removes the argument on the "who is working on pam" part. Atleast as a port, it makes sure the user has to manually install the port, so noone can complain that FreeBSD is forcing this onto the users. IMHO a good solution. Personally I really don't care if the name is long, aslong as it is unique and related to what the port actually is. FreeBSD Ports (and all the other opensource systems) is filled with small TLA programs, that have names that not necessarily give away clues towards what the port is doing. And yes I know about the "make search" tool, I only feel that making a port name logical is a good thing to do. =) Just my $0.02 //Svein -- /"\ ASCII Ribbon Campaign . \ / - NO HTML/RTF in e-mail . X - NO Word docs in e-mail . / \ ----------------------------------------------------------------- Svein Skogen efnet oper, irc.light.se tds@dmnshq.net efnet oper, irc.webgiro.se --------------------------------------------------------------------- Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020307114210.A25376>