Date: Tue, 21 Mar 2017 10:57:53 -0700 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r436576 - in head/emulators/wine-devel: . files Message-ID: <20170321175753.GV23308@FreeBSD.org> In-Reply-To: <alpine.LNX.2.21.1703211835270.28312@anthias.pfeifer.com> References: <201703210858.v2L8w0Zr014870@repo.freebsd.org> <alpine.LNX.2.21.1703211835270.28312@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Gerald, On Tue, Mar 21, 2017 at 06:43:01PM +0100, Gerald Pfeifer wrote: G> On Tue, 21 Mar 2017, Gleb Smirnoff wrote: G> > Log: G> > Make it compilable on FreeBSD 12 after struct inpcb and struct tcpcb G> > were stopped being exported. G> > Added: G> > head/emulators/wine-devel/files/patch-dlls_iphlpapi_ipstats.c (contents, props changed) G> G> thanks for creating a fix for this and sharing it. G> G> > +PORTREVISION= 1 G> G> This actually isn't necessary and triggers a needless rebuild for G> users on older versions of FreeBSD than that. G> G> (When the build is broken under some circumstances, but not others, G> simply fixing it is sufficient.) G> G> This is why (gentle hint) it actually does make sense to working G> with the maintainer of a port instead of just committing a fix. :-) But without the bump I can't enforce rebuild for FreeBSD 12 users, can I? G> > Added: head/emulators/wine-devel/files/patch-dlls_iphlpapi_ipstats.c G> > ============================================================================== G> G> Have you submitted this upstream as well? We should minimize local G> patches like this, not the least since some people (and my nightly G> automated tester, for example) also build from upstream sources. G> G> And it adds maintenance overhead over time. G> G> G> If you have not submitted it yet, G> https://wiki.winehq.org/Submitting_Patches G> has good information (if a bit much I'll admit) and I'll be happy G> to help. G> G> At a minimum, if you don't want to follow the regular process, G> sending it to wine-patches@winehq.com copying me would be good. Once I'm done with settling dust after this change, I am going to go through all my commits and try to upstream all of them. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170321175753.GV23308>