Date: Tue, 20 Oct 2015 01:54:34 +0000 (UTC) From: "Conrad E. Meyer" <cem@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r289615 - head/sys/dev/ntb/if_ntb Message-ID: <201510200154.t9K1sYq6031061@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: cem Date: Tue Oct 20 01:54:34 2015 New Revision: 289615 URL: https://svnweb.freebsd.org/changeset/base/289615 Log: if_ntb: Fix typo in qp_link_work to match Linux Throw away the result of the peer SPAD read. The peer will write our local SPAD and we need to keep the locally read SPAD value to check if the remote side is up. Sponsored by: EMC / Isilon Storage Division Modified: head/sys/dev/ntb/if_ntb/if_ntb.c Modified: head/sys/dev/ntb/if_ntb/if_ntb.c ============================================================================== --- head/sys/dev/ntb/if_ntb/if_ntb.c Tue Oct 20 01:54:25 2015 (r289614) +++ head/sys/dev/ntb/if_ntb/if_ntb.c Tue Oct 20 01:54:34 2015 (r289615) @@ -1381,14 +1381,14 @@ ntb_qp_link_work(void *arg) struct ntb_transport_qp *qp = arg; struct ntb_softc *ntb = qp->ntb; struct ntb_transport_ctx *nt = qp->transport; - int val; + uint32_t val, dummy; ntb_spad_read(ntb, IF_NTB_QP_LINKS, &val); ntb_peer_spad_write(ntb, IF_NTB_QP_LINKS, val | (1ull << qp->qp_num)); /* query remote spad for qp ready bits */ - ntb_peer_spad_read(ntb, IF_NTB_QP_LINKS, &val); + ntb_peer_spad_read(ntb, IF_NTB_QP_LINKS, &dummy); /* See if the remote side is up */ if ((val & (1ull << qp->qp_num)) != 0) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201510200154.t9K1sYq6031061>