Date: Wed, 7 Oct 2015 11:08:13 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: NGie Cooper <yaneurabeya@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r288981 - head/sbin/sysctl Message-ID: <20151007090812.GA91729@ivaldir.etoilebsd.net> In-Reply-To: <52FE118F-5C0E-4CC2-9078-27015D72315B@gmail.com> References: <201510070856.t978u2mZ048215@repo.freebsd.org> <52FE118F-5C0E-4CC2-9078-27015D72315B@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Oct 07, 2015 at 01:58:29AM -0700, NGie Cooper wrote: > > > On Oct 7, 2015, at 01:56, Baptiste Daroussin <bapt@FreeBSD.org> wrote: > > > > Author: bapt > > Date: Wed Oct 7 08:56:01 2015 > > New Revision: 288981 > > URL: https://svnweb.freebsd.org/changeset/base/288981 > > > > Log: > > Trim spaces at the end of the buffer before trying to convert it to an oid > > > > This allows to write entries in sysctl.conf with spaces before the '=' like > > kern.ipc.shmmax = 9663676416 > > > > MFC after: 1 week > > Sponsored by: Gandi.net > > Won’t this cause issues if the intent of the original value is to have a space before the rest of the value, e.g. > > sysctl my.oid=“ i really wanted a leading space” Note that here I am only trimming spaces _before_ the = and I'm not touching the parsing after the '=' for the exact reason you are raising. Best regards, Bapt [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlYU4PwACgkQ8kTtMUmk6EyepwCfV9thV+voILJFAMtZ9uUA+6Sy qUwAn3eiyos1gVtzynuUjpxBpLMKpcOM =Jvmf -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151007090812.GA91729>