Date: Thu, 27 Nov 2008 10:35:51 -0800 From: Sam Leffler <sam@freebsd.org> To: Ivan Voras <ivoras@gmail.com> Cc: svn-src-head@freebsd.org, =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r185356 - head/sys/dev/ixgbe Message-ID: <492EE887.8080901@freebsd.org> In-Reply-To: <9bbcef730811270238k61c3e59fqee7715f017d70ccf@mail.gmail.com> References: <200811270219.mAR2Ji2M073024@svn.freebsd.org> <20081126213204.14db9a63@kan.dnsalias.net> <20081127.000621.1413927847.imp@bsdimp.com> <9bbcef730811270220h1a7f812k2ba340737132ff82@mail.gmail.com> <8663m94g30.fsf@ds4.des.no> <9bbcef730811270238k61c3e59fqee7715f017d70ccf@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ivan Voras wrote:
> 2008/11/27 Dag-Erling Smørgrav <des@des.no>:
>
>> "Ivan Voras" <ivoras@gmail.com> writes:
>>
>>> And at least the newer GEOM code also uses c99 variable declarations
>>> (not only for initializers - they were c99 from the start).
>>>
>> I'm curious about what you mean with "c99 variable declarations". If
>> you are referring to loop variable declarations, I can only find two
>> cases, both in g_linux_lvm.c. Other than that and mixing declarations
>> with statements (which style(9) explicitly forbids), there is no
>> difference between c89 to c99 as far as variable declarations are
>> concerned.
>>
>
> Yes, but not only loops - I mean things like:
>
> if () {
> struct *something abc;
> int y;
> ...
> }
>
> You'll probably find my code is one the biggest users of this style
> but I've only started using it when I saw it already used.
>
>
Repeat after me: "style is a guideline and not a contract".
Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?492EE887.8080901>