Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 19 Aug 2010 13:09:22 -0700
From:      Doug Barton <dougb@FreeBSD.org>
To:        Li-Wen Hsu <lwhsu@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, Jui-Nan Lin <jnlin@csie.nctu.edu.tw>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/www Makefile ports/www/trafficserver Makefile distinfo pkg-descr pkg-plist ports/www/trafficserver/files patch-rc__Makefile trafficserver.in
Message-ID:  <4C6D8F72.9090905@FreeBSD.org>
In-Reply-To: <201008161543.o7GFhwfs045965@repoman.freebsd.org>
References:  <201008161543.o7GFhwfs045965@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
Couple of minor tweaks. We prefer ports scripts to REQUIRE: LOGIN unless 
there is a reason not to, KEYWORD: shutdown is preferred for scripts 
that start persistent services, and "empty default" variable assignments 
are neither necessary nor desirable.


hth,

Doug


On 08/16/2010 08:43, Li-Wen Hsu wrote:
> lwhsu       2010-08-16 15:43:58 UTC
>
>    FreeBSD ports repository
>
>    Modified files:
>      www                  Makefile
>    Added files:
>      www/trafficserver    Makefile distinfo pkg-descr pkg-plist
>      www/trafficserver/files patch-rc__Makefile trafficserver.in
>    Log:
>    Add trafficserver 2.1.1, a fast, scalable and extensible HTTP proxy
>    server.
>
>    PR:             ports/149676  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=149676
>    Submitted by:   Jui-Nan Lin<jnlin at csie.nctu.edu.tw>
>
>    Revision  Changes    Path
>    1.2660    +1 -0      ports/www/Makefile
>    1.1       +41 -0     ports/www/trafficserver/Makefile (new)
>    1.1       +3 -0      ports/www/trafficserver/distinfo (new)
>    1.1       +12 -0     ports/www/trafficserver/files/patch-rc__Makefile (new)
>    1.1       +20 -0     ports/www/trafficserver/files/trafficserver.in (new)
>    1.1       +6 -0      ports/www/trafficserver/pkg-descr (new)
>    1.1       +272 -0    ports/www/trafficserver/pkg-plist (new)
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/Makefile.diff?&r1=1.2659&r2=1.2660&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/trafficserver/Makefile
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/trafficserver/distinfo
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/trafficserver/files/patch-rc__Makefile
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/trafficserver/files/trafficserver.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/trafficserver/pkg-descr
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/trafficserver/pkg-plist
>



-- 

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/

	Computers are useless. They can only give you answers.
			-- Pablo Picasso


[-- Attachment #2 --]
Index: trafficserver.in
===================================================================
RCS file: /home/pcvs/ports/www/trafficserver/files/trafficserver.in,v
retrieving revision 1.1
diff -u -r1.1 trafficserver.in
--- trafficserver.in	16 Aug 2010 15:43:58 -0000	1.1
+++ trafficserver.in	19 Aug 2010 20:07:25 -0000
@@ -4,7 +4,8 @@
 #
 
 # PROVIDE: trafficserver
-# REQUIRE: DAEMON
+# REQUIRE: LOGIN
+# KEYWORD: shutdown
 
 . /etc/rc.subr
 
@@ -14,7 +15,7 @@
 procname="%%PREFIX%%/bin/traffic_server"
 
 load_rc_config "$name"
+
 : ${trafficserver_enable="NO"}
-: ${trafficserver_flags=""}
 
 run_rc_command "$1"

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C6D8F72.9090905>