Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 Jul 2018 11:11:05 -0600
From:      Brad Davis <brd@FreeBSD.org>
To:        Shawn Webb <shawn.webb@hardenedbsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r336744 - in head: sbin/pfctl/tests/files share/mk
Message-ID:  <1532625065.2234037.1453936096.39AD7179@webmail.messagingengine.com>
In-Reply-To: <20180726170900.twg3qeh34wmaerul@mutt-hbsd>
References:  <201807261705.w6QH5Y1D034822@repo.freebsd.org> <20180726170900.twg3qeh34wmaerul@mutt-hbsd>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 26, 2018, at 11:09 AM, Shawn Webb wrote:
> On Thu, Jul 26, 2018 at 05:05:34PM +0000, Brad Davis wrote:
> > Author: brd
> > Date: Thu Jul 26 17:05:33 2018
> > New Revision: 336744
> > URL: https://svnweb.freebsd.org/changeset/base/336744
> > 
> > Log:
> >   Convert bsd.files.mk to support DIRS and simplify by only having one install
> >   target.
> >   
> >   Also update the pfctl tests Makefile to work with this change.
> >   
> >   Approved by:	bapt (mentor)
> >   Differential Revision:	https://reviews.freebsd.org/D16430
> > 
> > Modified:
> >   head/sbin/pfctl/tests/files/Makefile
> >   head/share/mk/bsd.files.mk
> > 
> > Modified: head/sbin/pfctl/tests/files/Makefile
> > ==============================================================================
> > --- head/sbin/pfctl/tests/files/Makefile	Thu Jul 26 16:51:23 2018	(r336743)
> > +++ head/sbin/pfctl/tests/files/Makefile	Thu Jul 26 17:05:33 2018	(r336744)
> > @@ -4,9 +4,7 @@ TESTSDIR=	${TESTSBASE}/sbin/pfctl/files
> >  BINDIR=		${TESTSDIR}
> >  
> >  # We use ${.CURDIR} as workaround so that the glob patterns work.
> > -FILES=		${.CURDIR}/pf????.in
> > -FILES+=		${.CURDIR}/pf????.include
> > -FILES+=		${.CURDIR}/pf????.ok
> > +FILES!=		echo ${.CURDIR}/pf????.in ${.CURDIR}/pf????.include ${.CURDIR}/pf????.ok
> 
> Should this use ${ECHO} instead of echo?

No, that wouldn't work at all with the !=.


Regards,
Brad Davis



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1532625065.2234037.1453936096.39AD7179>