Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Jan 2019 04:54:37 -0800
From:      Cy Schubert <Cy.Schubert@cschubert.com>
To:        Eugene Grosbein <eugen@grosbein.net>
Cc:        Maxim Sobolev <sobomax@freebsd.org>, Cy Schubert <Cy.Schubert@cschubert.com>, "Conrad E. Meyer" <cem@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r343118 - in head/usr.sbin: . trim
Message-ID:  <201901181254.x0ICsbBb076360@slippy.cwsent.com>
In-Reply-To: Message from Eugene Grosbein <eugen@grosbein.net> of "Fri, 18 Jan 2019 16:17:04 %2B0700." <81bb343b-ad8a-371d-d94f-f72c8dbce754@grosbein.net>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <81bb343b-ad8a-371d-d94f-f72c8dbce754@grosbein.net>, Eugene 
Grosbein
 writes:
> 18.01.2019 5:25, Maxim Sobolev wrote:
>
> > Using usr.sbin/trim as an example. 
>
> We still lack a command usable at installation stage (escape to shell) to tri
> m a device or partition
> dedicated to ZFS Cache/ZFS Intention Log/zvol any other use when ports/packag
> es are not yet available.

OK, I will put a review together for dd.

Do you realize that what you just said? Your statement is inconsistent 
with where trim is installed? Then it should have been installed in 
/sbin not where you put it. I don't want to start yet another bikeshed 
arguing the merits of this or that -- I'm intentionally being vague 
here because I really don't want to stat a different bikeshed thread. 
But suffice it to say, dd is the place for it because it lives in /bin 
and dd is already included in /rescue.

Everything about trim is wrong, even where it is put.


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201901181254.x0ICsbBb076360>