Date: Sat, 07 Jan 2023 11:48:53 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 268776] audio/d11amp 0.61: New port 3 Message-ID: <bug-268776-7788-VBkR8N2Km0@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-268776-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-268776-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268776 Felix Palmen <zirias@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zirias@freebsd.org Assignee|ports-bugs@FreeBSD.org |zirias@freebsd.org Status|New |Open --- Comment #1 from Felix Palmen <zirias@freebsd.org> --- (In reply to Thomas Dettbarn from comment #0) Thanks, this looks *almost* perfect. A style nitpick: PLIST_FILES belongs *after* the "make block" (where you de= fine your TEST stuff). And then, as your upstream *does* respect DESTDIR now, the whole do-install: rule should be unnecessary. I will just test that now (will take a while ag= ain as I have to rebuild lots of updated packages ...) A little tip for upstream: you could make it even more flexible using a structure e.g. like this: --- PREFIX?=3D/usr/local BINDIR?=3D$(PREFIX)/bin MANDIR?=3D$(PREFIX)/share/man INSTALLBIN=3D$(DESTDIR)$(BINDIR) ... --- But it's of course fine as it is now for packaging purposes! --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-268776-7788-VBkR8N2Km0>