Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Mar 2022 12:08:23 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 262590] [pf] Anchor "blacklistd/*" not correctly shown in pfctl -a \* -s rules
Message-ID:  <bug-262590-227-XtQZksR9NI@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-262590-227@https.bugs.freebsd.org/bugzilla/>

index | next in thread | previous in thread | raw e-mail

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262590

--- Comment #7 from Matteo Riondato <matteo@FreeBSD.org> ---
Created attachment 232549
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=232549&action=edit
Patch that fixes the issue for me

The attached patch fixes the above case for me, but it may break other cases
that I am not aware of, as I cannot understand why the previous use of strrchar
would ever be the right thing to do. If you explain it to me, I can update the
patch accordingly (there are other things I don't understand here, e.g., why if
anchor_call contains '_' then we should do something special).

I assumed that anchor_call will never be shorter than 2 if it has a '*' as last
character (because then it must have "/*", but I may be wrong about it, and one
should do a dance similar to that done for the parsing of the argument to -a on
the command line. Please let me know what you think, and I can update the
patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-262590-227-XtQZksR9NI>