Date: Fri, 25 Jan 2019 06:00:47 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Kyle Evans <self@kyle-evans.net> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, Ram Kishore Vegesna <ram.vegesna@broadcom.com>, Ram Kishore Vegesna <ram@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343349 - head/sys/dev/ocs_fc Message-ID: <201901251400.x0PE0lrG088749@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CACNAnaH9U4A8VwAW8MjyxvfKJQ7NSqkgF4o9Jj=WF7YWpt6Onw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Fri, Jan 25, 2019 at 7:44 AM Rodney W. Grimes > <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > Hi Rodney, > > > > > > I fixed many coverity tool warnings as part of this commit. Adding all the > > > warnings and fix details seemed over kill. > > > > It seems like overkill when your commiting, but if you have > > have to go digging through commit history trying to find > > something it helps a great deal to have good information > > present there. > > > > You do not need to include the output from coverty, > > but some amount of detail is very helpful. > > > > We do have a tendency to note CIDs in commit messages and that's pretty > helpful -- I don't know that omitting them will generally ruffle any > feathers, though. yes, CIDs are fine, I should of clarified that, I would not want to see the full output from coverty in a commit message unless it was needed to express what was fixed and why in some way. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201901251400.x0PE0lrG088749>