Date: Fri, 7 Aug 2020 11:57:21 -0500 From: Kyle Evans <kevans@freebsd.org> To: Alexander Richardson <arichardson@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r364023 - head/usr.bin/grep Message-ID: <CACNAnaHYC3xE-nuMxsD3LZ%2BWW2u-2zxmstBJjDPhOyVPQ7D0Yg@mail.gmail.com> In-Reply-To: <CA%2BZ_v8oJ-k3Nb9UDAHonGvdvDx3yL5zKG1dUUFyXQLc1UOCaVA@mail.gmail.com> References: <202008071604.077G41dj025962@repo.freebsd.org> <CACNAnaHvJOBTXrjK-knfmK1VARHwVqQ3G84h0uTE=rmK6ftTMg@mail.gmail.com> <CA%2BZ_v8oJ-k3Nb9UDAHonGvdvDx3yL5zKG1dUUFyXQLc1UOCaVA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 7, 2020 at 11:22 AM Alexander Richardson <arichardson@freebsd.org> wrote: > > On Fri, 7 Aug 2020 at 17:06, Kyle Evans <kevans@freebsd.org> wrote: > > > > On Fri, Aug 7, 2020 at 11:04 AM Alex Richardson <arichardson@freebsd.org> wrote: > > > > > > Author: arichardson > > > Date: Fri Aug 7 16:04:01 2020 > > > New Revision: 364023 > > > URL: https://svnweb.freebsd.org/changeset/base/364023 > > > > > > Log: > > > Always install usr.bin/grep as grep when bootstrapping > > > > > > We have to bootstrap grep when cross-building from macOS/Linux. > > > > > > > What's going on here that it isn't bootstrapping gnugrep over in > > gnu/usr.bin/grep as grep? My gut instinct is that we're missing > > something else and this isn't quite the right place to have addressed > > this. > > > > The logic in Makefile.inc1 builds usr.bin/grep as the bootstrap grep > when BOOTSTRAP_ALL_TOOLS is set (e.g. when building on macOS/Linux). > If you think this should be gnu/usr.bin/grep instead I can revert this > change and update Makefile.inc1. > We have been using usr.bin/grep for bootstrap in CheriBSD for a long > time now and it works fine so I'm not sure whether we need to use GNU > grep for bootstrapping? > I suspect that the correct path should've forced WITH_BSD_GREP at the top-level if it's going to explicitly use usr.bin/grep, but now that I think about it- let's not put any more thought into this... Ultimately, I'm going to be reverting this in due time as I flip the WITH_BSD_GREP switch to default and ultimately remove the whole conditional altogether not too long after that. This will remove the need completely. Thanks, Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaHYC3xE-nuMxsD3LZ%2BWW2u-2zxmstBJjDPhOyVPQ7D0Yg>