Date: Wed, 20 Nov 2019 23:30:57 -0700 From: Warner Losh <imp@bsdimp.com> To: Dimitry Andric <dim@freebsd.org> Cc: John Baldwin <jhb@freebsd.org>, "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r354900 - head/usr.sbin/jail Message-ID: <CANCZdfrRmmmUjK_qF13gjZ9Rj-7NG0WDtpdGx4s5KtRzHTu0UA@mail.gmail.com> In-Reply-To: <5E3130FE-7763-4942-997C-0E325DCF48E6@FreeBSD.org> References: <201911201654.xAKGsMTv094014@repo.freebsd.org> <CANCZdfqVLZUqGiCDagwkULH7xegrZwehRsn8Ek-BJR=OVTpXGw@mail.gmail.com> <59bf120c-2f35-1a22-b6fa-a9c9bb8cfdf4@FreeBSD.org> <CANCZdfoG198Qqj90NS=NZ_%2BsMWoEPffGcJJmg25u4U97KgPfBQ@mail.gmail.com> <991bdc33-516d-6e6d-1880-44930441893d@FreeBSD.org> <A9CE2EDE-BF95-41EA-9F21-868804E992A2@lists.zabbadoz.net> <5d4541f5-fe6c-ecc7-c383-0dfd9596ec0f@FreeBSD.org> <5E3130FE-7763-4942-997C-0E325DCF48E6@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 20, 2019 at 11:19 PM Dimitry Andric <dim@freebsd.org> wrote:
> On 21 Nov 2019, at 01:44, John Baldwin <jhb@FreeBSD.org> wrote:
> >
> > On 11/20/19 3:42 PM, Bjoern A. Zeeb wrote:
> >> On 20 Nov 2019, at 23:32, John Baldwin wrote:
> ...
> >> You can however find more of these elsewhere:
> >>
> >> ../lib/libc/tests/sys/Makefile:.if ${MACHINE_CPUARCH} != "aarch64" &&
> >> ${MACHINE_CPUARCH} != "riscv"
> >> ../lib/libcompiler_rt/Makefile.inc:.if ${MACHINE_CPUARCH} == "aarch64"
> >> || ${MACHINE_CPUARCH} == "riscv"
> >> ../stand/libsa/Makefile:.if ${MACHINE_CPUARCH} == "aarch64" ||
> >> ${MACHINE_CPUARCH} == "riscv"
> >> ../usr.bin/Makefile:.if ${MACHINE_ARCH} != "aarch64" &&
> >> ${MACHINE_CPUARCH} != "riscv"
> >> ../usr.bin/gprof/Makefile:.if ${MACHINE_ARCH} != "aarch64" &&
> >> ${MACHINE_ARCH} != "riscv" && \
> >
> > The tests comparing MACHINE_CPUARCH against aarch64 are confusing indeed.
> > My understanding is that MACHINE_CPUARCH is arm64 for aarch64? It's kind
> > of hard to guess since arch(7) goes to great length to try to describe
> > these variables but doesn't give a handy table of what they actually are
> > for the various architectures.
>
> Yes, such a table would be extremely helpful. :)
>
Fair point. It does go on at length for all the MACHINE_ARCH types, but
doesn't list the plain MACHINE_CPUARCH. In all cases, it is either the one
MACHINE_ARCH supported, or the common prefix of all the MACHINE_ARCH
supported (though when we delete armv5, that will become slightly
inaccurate, so a table is likely good).
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrRmmmUjK_qF13gjZ9Rj-7NG0WDtpdGx4s5KtRzHTu0UA>