Date: Fri, 20 Jul 2007 21:06:53 +0800 From: chinsan <chinsan.tw@gmail.com> To: pav@freebsd.org Cc: doc-committers@freebsd.org, cvs-doc@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: doc/en_US.ISO8859-1/books/porters-handbook book.sgml Message-ID: <1f27304c0707200606s32541002g488f2f1a92ff8f21@mail.gmail.com> In-Reply-To: <1184936122.13381.28.camel@pav.hide.vol.cz> References: <200707201246.l6KCkC8M062760@repoman.freebsd.org> <1184936122.13381.28.camel@pav.hide.vol.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/20/07, Pav Lucistnik <pav@freebsd.org> wrote:
> Chin-San Huang p=ED=9Ae v p=E1 20. 07. 2007 v 12:46 +0000:
> > chinsan 2007-07-20 12:46:12 UTC
> >
> > FreeBSD doc repository
> >
> > Modified files:
> > en_US.ISO8859-1/books/porters-handbook book.sgml
> > Log:
> > - Fix typo.
> >
> > "If a port insists on linking -lpthread or -lc_r directly, patch it t=
o use
> > PTHREAD_LIBS variable provided by the ports framework."
> >
> > Noticed by: kevlo
> >
> > Revision Changes Path
> > 1.858 +1 -1 doc/en_US.ISO8859-1/books/porters-handbook/book.=
sgml
>
> That's actually not a typo. The text should read
>
> on linking -pthread, -lpthread or -lc_r
>
> --
> Pav Lucistnik <pav@oook.cz>
> <pav@FreeBSD.org>
>
> Sword ownership rights have been under heavy fire since they were
> determined to be the leading cause of death during the Siege of Acre
> in the third crusade.
Hi, Pav:
The Original:
@${REINPLACE_CMD} -e 's|-pthread|${PTHREAD_LIBS}|' ${WRKSRC}/configure
The patched:
@${REINPLACE_CMD} -e 's|-lpthread|${PTHREAD_LIBS}|' ${WRKSRC}/configur=
e
Since "PTHREAD_LIBS?=3D -pthread", so why we should replace it again?
Therefore, it was guessed as a typo of "-lpthread" instead of "-pthread".
Because PTHREAD_LIBS =3D -pthread. :)
The following text is just a quote
"If a port insists on linking -lpthread or -lc_r directly, patch it to use
PTHREAD_LIBS variable provided by the ports framework."
- chinsan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1f27304c0707200606s32541002g488f2f1a92ff8f21>