Date: Sat, 8 Jan 2005 14:20:44 +0100 From: Michael Nottebrock <michaelnottebrock@gmx.net> To: freebsd-current@freebsd.org Cc: Jose M Rodriguez <josemi@freebsd.jazztel.es> Subject: Re: Xorg ICE vs. Xfce4 (4.2-RC3) needs fixing /etc/rc.d/cleartmp Message-ID: <200501081420.48513.michaelnottebrock@gmx.net> In-Reply-To: <20050107182024.GB30931@odin.ac.hmc.edu> References: <41DDC4F2.5090709@yahoo.com> <41DE5242.4030606@redesjm.local> <20050107182024.GB30931@odin.ac.hmc.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1376082.exaLAAoDCe Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Friday, 7. January 2005 19:20, Brooks Davis wrote: > On Fri, Jan 07, 2005 at 10:11:30AM +0100, Jose M Rodriguez wrote: > > Brooks Davis escribi=F3: > > >Could you please try the following patch? It does the same thing, but > > >gives the inode paranoid a way to disable the creation of these > > >directories or only create the ones they need. > > > > > >-- Brooks > > > > > >Index: rc.d/cleartmp > > >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > >RCS file: /usr/cvs/src/etc/rc.d/cleartmp,v > > >retrieving revision 1.11 > > >diff -u -p -r1.11 cleartmp > > >--- rc.d/cleartmp 7 Oct 2004 13:55:25 -0000 1.11 > > >+++ rc.d/cleartmp 7 Jan 2005 00:31:51 -0000 > > >@@ -35,5 +35,7 @@ run_rc_command "$1" > > ># restarting X > > ># > > >rm -f /tmp/.X[0-9]-lock > > >-rm -fr /tmp/.X11-unix > > >-mkdir -m 1777 /tmp/.X11-unix > > >+if [ -n ${clear_tmp_xdirs} ]; then > > >+ rm -fr ${clear_tmp_xdirs} > > >+ mkdir -m 1777 ${clear_tmp_xdirs} > > >+fi > > >Index: defaults/rc.conf > > >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > >RCS file: /usr/cvs/src/etc/defaults/rc.conf,v > > >retrieving revision 1.235 > > >diff -u -p -r1.235 rc.conf > > >--- defaults/rc.conf 15 Dec 2004 12:39:28 -0000 1.235 > > >+++ defaults/rc.conf 7 Jan 2005 00:30:49 -0000 > > >@@ -443,6 +443,8 @@ linux_enable=3D"NO" # Linux binary compati > > >svr4_enable=3D"NO" # SysVR4 emulation loaded at startup (or NO). > > >osf1_enable=3D"NO" # Alpha OSF/1 emulation loaded at startup (or NO). > > >clear_tmp_enable=3D"NO" # Clear /tmp at startup. > > >+clear_tmp_xdirs=3D"/tmp/.X11-unix /tmp/.font-unix /tmp/.ICE-unix" > > >+ # Directories needed by X11 > > >ldconfig_insecure=3D"NO" # Set to YES to disable ldconfig security > > >checks > > >ldconfig_paths=3D"/usr/lib/compat /usr/X11R6/lib /usr/local/lib > > >/usr/local/lib/compat/pkg" > > > # shared library search paths > > > > I recall putting this in a conf PR, try a follow-up. > > > > But I think your patch is a little bit wrong > > > > I never like the way X11 is taken by /etc/rc.d/cleartmp. none must be > > do after the run_rc_command. > > That's easy enough to fix. > > > If we need do this from the base system (Thing that I doubt more and > > more), this must be implementing a new /etc/rc.d/clearx11tmp (this may > > be do in the main /etc/rc.d/cleartmp, like in sendmail), with all the > > bits: clear_x11tmp_enable, clear_x11tmp_dirs, ... > > > > But I must point that: > > > > X11 is now mostly a ports thing, not a base system component. If this > > can be take from ports (I send-pr this also), this must be the path to > > the solution. I put a simple script from libs, but I can work and rcNG > > enabled thing if prefered. > > > > This is not what x11 really needs. x11 only needs some like this: mkdir > > -p ... && chown root:wheel ... && chmod 01777 ... . this may be > > prefered by the x11 team. > > > > This can be taken both from base and ports without too much problem. > > The only secondary effect of this I know is that you may polite /tmp > > entries twice, with is not a real pain to the whole boot process. > > My worry with using your patch is that localpkg is run quite late in the > startup process, well after X may have tried to start if xdm is run from > /etc/ttys. Are you sure about that? I didn't look at any code now, but I'm quite sure = I=20 never saw any system pop up a tty at me before running the local rc scripts= =20 (actually, the only thing that happens after the ttys are up is, to my=20 knowledge, background fsck). =2D-=20 ,_, | Michael Nottebrock | lofi@freebsd.org (/^ ^\) | FreeBSD - The Power to Serve | http://www.freebsd.org \u/ | K Desktop Environment on FreeBSD | http://freebsd.kde.org --nextPart1376082.exaLAAoDCe Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQBB394wXhc68WspdLARAv2OAJkBmGeklrqqBlbrmGJ4ItCKjNCCIwCdEMSZ /ZXhJNntH0y+Uz3Plc/0j+I= =hejL -----END PGP SIGNATURE----- --nextPart1376082.exaLAAoDCe--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200501081420.48513.michaelnottebrock>