Date: Wed, 11 Jun 2003 16:17:13 -0400 From: Garance A Drosihn <drosih@rpi.edu> To: "Scot W. Hetzel" <hetzels@westbend.net>, "Munehiro Matsuda" <haro@kgt.co.jp> Cc: gordon@bsd-network.org Subject: Re: BDECFLAGS being added to CFLAGS and CWARNFLAGS ( was Re: [solved] buildworld error) Message-ID: <p05210615bb0d3ccf55c0@[128.113.24.47]> In-Reply-To: <033701c3304f$c3a0a2a0$13fd2fd8@Admin02> References: <20030609210914.GA15553@nemesis.bsd-network.org><20030610194208.GA55855@ne mesis.bsd-network.org><p05210610bb0c1e58316f@[128.113.24.47]> <20030611.143132.74757193.haro@kgt.co.jp> <033701c3304f$c3a0a2a0$13fd2fd8@Admin02>
next in thread | previous in thread | raw e-mail | index | archive | help
At 2:29 PM -0500 6/11/03, Scot W. Hetzel wrote:
>From: "Munehiro Matsuda" <haro@kgt.co.jp>
> > I was having the same compile error, until I commeted out
> > the BDECFLAGS definition from /etc/make.conf.
> >
> > Looking into the problematic Makefiles, I've found that
> > following Makefiles do references BDECFLAGS, which matches
> > errors I was getting:
> >
>> usr.sbin/config/Makefile : CFLAGS+= ${BDECFLAGS}
>> usr.sbin/lpr/Makefile.inc: CWARNFLAGS= ${BDECFLAGS}
>> usr.sbin/kgzip/Makefile : CFLAGS+= ${BDECFLAGS}
>>
> > I think these references must be removed.
Ugh. Every time there's a scan for some bad-programming
practice, 'lpr' is one of the guilty parties... I'll fix
that one!
>I did a find for BDECFLAGS and it found 5 Makefiles that
>are adding these flags to either CFLAGS or CWARNFLAGS.
>
># cd /usr/src
># find . -type f -exec grep -H "BDECFLAGS" {} +
>./sbin/ffsinfo/Makefile:#CFLAGS+=${BDECFLAGS}
>./sbin/growfs/Makefile:#CFLAGS+=${BDECFLAGS}
>:
>./usr.sbin/config/Makefile:CFLAGS+= ${BDECFLAGS}
>./usr.sbin/lpr/Makefile.inc:CWARNFLAGS= ${BDECFLAGS}
>./usr.sbin/kgzip/Makefile:CFLAGS+= ${BDECFLAGS}
>
>A couple of possible fixes are:
> 1. removal of BDECFLAGS from the above files
> 2. Add a .ifdef USE_BDECFLAGS .. .endif, that
> conditionalizes the use of BDECFLAGS in the
> above files.
Ick. Then we'll need a "USE_USE_BDECFLAGS", to tell us if we
should pay attention to the USE_BDECFLAGS variable...
My guess is that there isn't a single reason that these five
programs need to reference BDECFLAGS, especially now that it
is no longer defined in /etc/defaults/make.conf . We should
just remove those references.
--
Garance Alistair Drosehn = gad@gilead.netel.rpi.edu
Senior Systems Programmer or gad@freebsd.org
Rensselaer Polytechnic Institute or drosih@rpi.edu
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p05210615bb0d3ccf55c0>