Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Aug 2022 15:27:41 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        John Baldwin <jhb@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>,  "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org
Subject:   Re: git: e66390736613 - main - Define _NPCM and the last PC_FREEn constant in terms of _NPCPV.
Message-ID:  <CANCZdfpGiWqsBbnFoGKnh_3cTVPCnR-bmgaQUQ1w9o_cD70V1A@mail.gmail.com>
In-Reply-To: <9108301c-5035-440f-0db0-a98b7465e297@FreeBSD.org>
References:  <202208232031.27NKVT2H033895@gitrepo.freebsd.org> <9108301c-5035-440f-0db0-a98b7465e297@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000002d8c7d05e72b96f8
Content-Type: text/plain; charset="UTF-8"

Hey John,

On Fri, Aug 26, 2022 at 12:10 PM John Baldwin <jhb@freebsd.org> wrote:

> On 8/23/22 1:31 PM, John Baldwin wrote:
> > The branch main has been updated by jhb:
> >
> > URL:
> https://cgit.FreeBSD.org/src/commit/?id=e66390736613a452238531f64bb9f674ebd4c3a6
> >
> > commit e66390736613a452238531f64bb9f674ebd4c3a6
> > Author:     John Baldwin <jhb@FreeBSD.org>
> > AuthorDate: 2022-08-23 20:31:02 +0000
> > Commit:     John Baldwin <jhb@FreeBSD.org>
> > CommitDate: 2022-08-23 20:31:02 +0000
> >
> >      Define _NPCM and the last PC_FREEn constant in terms of _NPCPV.
> >
> >      This applies one of the changes from
> >      5567d6b4419b02a2099527228b1a51cc55a5b47d to other architectures
> >      besides arm64.
> >
> >      Reviewed by:    kib
> >      Sponsored by:   DARPA
> >      Differential Revision:  https://reviews.freebsd.org/D36263
>
> So this actually broke emulators/qemu because <machine/pmap.h> now
> requires <sys/param.h>.  I have a patch to fix the port available at
> https://reviews.freebsd.org/D36362.  What I don't know is if there are
> other ports broken by this that might change how to address this?  I
> would mostly hope that <machine/pmap.h> wouldn't be a header that userland
> would need to use and that adding <sys/param.h> in a few places would
> be the end of it.  However, if there's wider-spread breakage then I
> would hack on this to avoid the need for <sys/param.h>.
>

This will break qemu building on FreeBSD in the 7.1 release. It's almost
out (last
rc is out and that's expected to be the actual release). Any chance we can
fix
this in our sources?

Warner

--0000000000002d8c7d05e72b96f8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hey John,<br></div><br><div class=3D"gmai=
l_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Aug 26, 2022 at 12:1=
0 PM John Baldwin &lt;<a href=3D"mailto:jhb@freebsd.org">jhb@freebsd.org</a=
>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px=
 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On =
8/23/22 1:31 PM, John Baldwin wrote:<br>
&gt; The branch main has been updated by jhb:<br>
&gt; <br>
&gt; URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3De66390736613=
a452238531f64bb9f674ebd4c3a6" rel=3D"noreferrer" target=3D"_blank">https://=
cgit.FreeBSD.org/src/commit/?id=3De66390736613a452238531f64bb9f674ebd4c3a6<=
/a><br>
&gt; <br>
&gt; commit e66390736613a452238531f64bb9f674ebd4c3a6<br>
&gt; Author:=C2=A0 =C2=A0 =C2=A0John Baldwin &lt;jhb@FreeBSD.org&gt;<br>
&gt; AuthorDate: 2022-08-23 20:31:02 +0000<br>
&gt; Commit:=C2=A0 =C2=A0 =C2=A0John Baldwin &lt;jhb@FreeBSD.org&gt;<br>
&gt; CommitDate: 2022-08-23 20:31:02 +0000<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 Define _NPCM and the last PC_FREEn constant in ter=
ms of _NPCPV.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 <br>
&gt;=C2=A0 =C2=A0 =C2=A0 This applies one of the changes from<br>
&gt;=C2=A0 =C2=A0 =C2=A0 5567d6b4419b02a2099527228b1a51cc55a5b47d to other =
architectures<br>
&gt;=C2=A0 =C2=A0 =C2=A0 besides arm64.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 <br>
&gt;=C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 kib<br>
&gt;=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0DARPA<br>
&gt;=C2=A0 =C2=A0 =C2=A0 Differential Revision:=C2=A0 <a href=3D"https://re=
views.freebsd.org/D36263" rel=3D"noreferrer" target=3D"_blank">https://revi=
ews.freebsd.org/D36263</a><br>
<br>
So this actually broke emulators/qemu because &lt;machine/pmap.h&gt; now<br=
>
requires &lt;sys/param.h&gt;.=C2=A0 I have a patch to fix the port availabl=
e at<br>
<a href=3D"https://reviews.freebsd.org/D36362" rel=3D"noreferrer" target=3D=
"_blank">https://reviews.freebsd.org/D36362</a>.=C2=A0 What I don&#39;t kno=
w is if there are<br>
other ports broken by this that might change how to address this?=C2=A0 I<b=
r>
would mostly hope that &lt;machine/pmap.h&gt; wouldn&#39;t be a header that=
 userland<br>
would need to use and that adding &lt;sys/param.h&gt; in a few places would=
<br>
be the end of it.=C2=A0 However, if there&#39;s wider-spread breakage then =
I<br>
would hack on this to avoid the need for &lt;sys/param.h&gt;.<br></blockquo=
te><div><br></div><div>This will break qemu building on FreeBSD in the 7.1 =
release. It&#39;s almost out (last</div><div>rc is out and that&#39;s expec=
ted to be the actual release). Any chance we can fix</div><div>this in our =
sources?</div><div><br></div><div>Warner=C2=A0</div></div></div>

--0000000000002d8c7d05e72b96f8--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpGiWqsBbnFoGKnh_3cTVPCnR-bmgaQUQ1w9o_cD70V1A>