Date: Sun, 10 Jun 2001 04:10:04 -0700 (PDT) From: Bruce Evans <bde@zeta.org.au> To: freebsd-bugs@FreeBSD.org Subject: Re: i386/28002: make world fails (ref. to ipf) Message-ID: <200106101110.f5ABA4p51835@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR i386/28002; it has been noted by GNATS.
From: Bruce Evans <bde@zeta.org.au>
To: Peter Wemm <peter@wemm.org>
Cc: freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: i386/28002: make world fails (ref. to ipf)
Date: Sun, 10 Jun 2001 20:58:06 +1000 (EST)
[Cc corrected]
On Sun, 10 Jun 2001, Peter Wemm wrote:
> Bruce Evans wrote:
> > On Sat, 9 Jun 2001, Peter Wemm wrote:
> >
> > > reel@sympatico.ca wrote:
> > >
> > > > >Description:
> > > > When doing a "make world", it seems that it has a problem with
> > > > sys/netinet/ip_compat.h
> > > > I get the message:
> > > > ===> sbin/ipf
> > > > make: don't know how to make /usr/src/sbin/ipf/../../sys/netinet/ip_comp
> at.h.
> > >
> > > This is because of either:
> > > 1) You are using 'make -DNOCLEAN world' (dont do this) and you have a stal
> e
> > > .depend file
> > > or
> > > 2) Something is stale in your obj directory. rm -rf /usr/obj/*
> >
> > This is actually because the SHARED=symlinks case was broken by moving
> > ipfilter, despite this case being the usual case for makeworld. From
> > src/Makefile.inc1:
> >
> > @echo "--------------------------------------------------------------"
> > @echo ">>> stage 4: populating ${WORLDTMP}/usr/include"
> > @echo "--------------------------------------------------------------"
> > cd ${.CURDIR}; ${WMAKE} SHARED=symlinks includes
>
> SHARED=symlinks may be broken, but it isn't causing world to die. I have
> two recent -stable (as little as 10 minutes ago) builds that I can show you
> if you dont believe me.
That is another bug :-). You must have garbage in /usr/include/netinet
from a previous installworld. Buildworld picks up this garbage because
-nostdinc was removed from CFLAGS in rev.1.105 of src/Makefile.inc1.
> The actual error message comes from stale .depend data. That is the only
> way that make ever gets told about the existance of
> "/usr/src/sbin/ipf/../../sys/netinet/ip_compat.h"
Yes. I haven't actually run makeworld to test this and jumped to some
conclusions.
> See the CFLAGS in -stable:
> CFLAGS+=-DIPL_NAME=\"/dev/ipl\" -I- -I${.CURDIR}/../../sys/netinet \
> -I${.CURDIR}/../../contrib/ipfilter
>
> These should be changed to ../../sys/contrib/ipfilter/netinet for -stable.
>
> However, this is not breaking the build. It may not be correct, but it
> is not causing an abort. Stale .depend data is causing the make failures.
>
> It is also broken on -current for different reasons. Sometimes it uses the
> ones from sys/netinet via the installed includes, and other times it uses
> the ones in ../../contrib/ipfilter (when doing #include "ip_compat.h" etc).
It seems to only find "ip_compat.h" there. This is enough to build ipf.
ipmon apparently uses <netinet/foo.h> so it doesn't build unless the
ipfilter headers are in a subdir named netinet somewhere (and a default
or -I path to the directory above).
> Somebody got carried away in removing -I../../sys in -current and broke
> things even more by removing -I../../sys/netinet at the same time.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200106101110.f5ABA4p51835>