Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 23 Feb 2001 17:39:43 +1100 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        Doug Rabson <dfr@nlsystems.com>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject:   Re: cvs commit: src/sys/alpha/alpha swtch.s
Message-ID:  <Pine.BSF.4.21.0102231727190.8957-100000@besplex.bde.org>
In-Reply-To: <XFMail.010222075403.jhb@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 22 Feb 2001, John Baldwin wrote:

> I've thought about doing that, yes.  If you want, I can stick it on my todo
> list.  Also, I have managed to make userret() and ast() (modulo a few commits
> coming up in the next 15 minutes or so) the same across all architectures.
> Do you think that given that it would be feasible to move those two functions
> to sys/kern/subr_trap.c and let them be MI?

I'm not sure that ast() should be MI.  It was in hardware on vaxes.

> Also, as a sidenote, I think that addupc_task() should take a uniptr_t, not a
> uint64_t as its second argument..

Nah, uniptr_t (sic) only exists on vaxes where all types are the same :-).

I think it should take a register_t or uintfptr_t.  uintptr_t is only
required to work for object pointers.  Instruction pointer values in
trap frames aren't even C pointers.  They normally (should) have type
register_t.  However, the parts of the profiling code that I cleaned
up used uintfptr_t or intfptr_t for representing instruction pointer
values.

Bruce



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0102231727190.8957-100000>