Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Aug 2016 09:40:12 -0700
From:      John Baldwin <jhb@freebsd.org>
To:        "Bjoern A. Zeeb" <bz@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r303963 - head/sys/powerpc/include
Message-ID:  <1743387.a2iKJ8FVcJ@ralph.baldwin.cx>
In-Reply-To: <201608111506.u7BF6DX4046653@repo.freebsd.org>
References:  <201608111506.u7BF6DX4046653@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, August 11, 2016 03:06:13 PM Bjoern A. Zeeb wrote:
> Author: bz
> Date: Thu Aug 11 15:06:12 2016
> New Revision: 303963
> URL: https://svnweb.freebsd.org/changeset/base/303963
> 
> Log:
>   Revert r303890 for now here as camdd fails to build on powerpc*
>   due to device_t only being available under _KERNEL.
>   
>   Reported by:	bde (_KERNEL in general), kib (build failure)
>   MFC after:	1 day
>   X-MFC with:	r303890

I think the real issue though is exposting this function prototype to
userland (I looked at it the other day).  camdd only wants bus_dma_segment_t.
It also explicitly includes <sys/bus_dma.h> which is a no-no.  I think this
should be fixed to either define a suitable bus_dma_segment_t explicitly
in libcam.h or the bus_dma headers have to all be audited to add
appropriate #ifdef _KERNEL guards.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1743387.a2iKJ8FVcJ>