Date: Sat, 23 Mar 2002 09:12:52 +0000 From: Mark Murray <mark@grondar.za> To: Mike Barcroft <mike@FreeBSD.ORG> Cc: audit@FreeBSD.ORG Subject: Re: chpass WARNS/lint fixes Message-ID: <200203230912.g2N9CqFc002263@grimreaper.grondar.org> In-Reply-To: <20020322223555.I80338@espresso.q9media.com> ; from Mike Barcroft <mike@FreeBSD.ORG> "Fri, 22 Mar 2002 22:35:55 EST." References: <20020322223555.I80338@espresso.q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> > @@ -39,10 +39,11 @@
> >
> > #ifndef lint
> > static const char sccsid[] = "From: @(#)chpass.c 8.4 (Berkeley) 4/2/94";
> > -static const char rcsid[] =
> > - "$FreeBSD: src/usr.bin/chpass/chpass.c,v 1.20 2002/03/22 01:19:26 imp Exp $";
> > #endif /* not lint */
>
> The vendor ID should be restored from Rev 1.1 and then wrapped in
> #if 0 ... #endif.
There is a __FBSDID() a little later. Or are you talking about $Id$ from the
original code?
> > +
> > +struct dom_binding {};
> > +
>
> This seems bogus; what is it used for?
Nothing. It is bogus. :-)
> The rest looks okay.
Take 2 is on its way.
M
--
o Mark Murray
\_
O.\_ Warning: this .sig is umop ap!sdn
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200203230912.g2N9CqFc002263>