Date: Mon, 28 Oct 2024 11:44:59 -0400 From: Cheng Cui <cc@freebsd.org> To: "Scheffenegger, Richard" <Richard.Scheffenegger@netapp.com> Cc: Gleb Smirnoff <glebius@freebsd.org>, "rscheff@freebsd.org" <rscheff@freebsd.org>, "tuexen@freebsd.org" <tuexen@freebsd.org>, "current@freebsd.org" <current@freebsd.org> Subject: Re: panic: tcp_do_segment: sent too much Message-ID: <CAGaXuiJTwKRNNW3UFHnLyLpqTc8FyAEJ%2Bc3TUEOq64p4GbBNLQ@mail.gmail.com> In-Reply-To: <PH0PR06MB76399FB248102627FAC49C6086492@PH0PR06MB7639.namprd06.prod.outlook.com> References: <Zx5sn1c1Iam8PrOw@cell.glebi.us> <PH0PR06MB76399FB248102627FAC49C6086492@PH0PR06MB7639.namprd06.prod.outlook.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sun, Oct 27, 2024 at 1:14 PM Scheffenegger, Richard < Richard.Scheffenegger@netapp.com> wrote: > > It's possible; > > D43355 and D43470 were quite strongly interrelated if my memory serves - > any currently only the former is committed. > > OK. I give D43470 a green light for now, based on my initial test result https://wiki.freebsd.org/chengcui/testD43470. Any bugs found shall be fixed after these two. 😉 cc -----Original Message----- > From: Gleb Smirnoff <glebius@freebsd.org> > Sent: Sonntag, 27. Oktober 2024 17:39 > To: rscheff@freebsd.org; tuexen@freebsd.org > Cc: current@freebsd.org > Subject: panic: tcp_do_segment: sent too much > > EXTERNAL EMAIL - USE CAUTION when clicking links or attachments > > > > > Hi, > > I just got this panic on my desktop running latest stabweek snapshot. > > panic: tcp_do_segment: sent too much > db_trace_self_wrapper() at db_trace_self_wrapper+0x2c/frame > 0xfffffe0209deb440 > kdb_backtrace() at kdb_backtrace+0x46/frame 0xfffffe0209deb4f0 > vpanic() at vpanic+0x23d/frame 0xfffffe0209deb630 > panic() at panic+0x4e/frame 0xfffffe0209deb690 > tcp_do_segment() at tcp_do_segment+0x3a6c/frame 0xfffffe0209deb8d0 > tcp_input_with_port() at tcp_input_with_port+0x15db/frame > 0xfffffe0209deba60 > tcp_input() at tcp_input+0x27/frame 0xfffffe0209deba90 > ip_input() at ip_input+0x1131/frame 0xfffffe0209debb00 > netisr_dispatch_src() at netisr_dispatch_src+0x18c/frame 0xfffffe0209debb70 > netisr_dispatch() at netisr_dispatch+0x21/frame 0xfffffe0209debb90 > ether_demux() at ether_demux+0x2a5/frame 0xfffffe0209debbd0 > ether_input_internal() at ether_input_internal+0x613/frame > 0xfffffe0209debc10 > ether_nh_input() at ether_nh_input+0xb1/frame 0xfffffe0209debc30 > netisr_dispatch_src() at netisr_dispatch_src+0x18c/frame 0xfffffe0209debca0 > netisr_dispatch() at netisr_dispatch+0x21/frame 0xfffffe0209debcc0 > ether_input() at ether_input+0x16c/frame 0xfffffe0209debd10 > > My kernel is compiled with -O0, which alleviates debugging: > > (kgdb) frame 4 > #4 0xffffffff80ea6c3c in tcp_do_segment (tp=0xfffff814a6f96000, > m=0xfffff8044d546a00, th=0xfffff8044d546a82, drop_hdrlen=64, tlen=0, > iptos=72 'H') at /usr/src/FreeBSD/sys/netinet/tcp_input.c:2812 > 2812 > KASSERT((tp->t_dupacks == 2 && > (kgdb) p tp->t_dupacks > $1 = 1 > (kgdb) p tp->snd_limited > $2 = 0 '\000' > (kgdb) p/x tp->t_flags > $4 = 0x110003e4 > (kgdb) p/x tp->t_flags & 0x00000010 # TF_SENTFIN > $5 = 0x0 > (kgdb) p tp->t_flags & 1 # TF_ACKNOW > $15 = 0 > (kgdb) p sent > $6 = 1507 > (kgdb) p maxseg > $7 = 1400 > (kgdb) p oldcwnd > $8 = 1400 > (kgdb) p oldsndmax > $9 = 2473784830 > (kgdb) p tp->snd_max > $10 = 2473786337 > (kgdb) p 2473786337 - 2473784830 > $11 = 1507 > (kgdb) p tp->snd_cwnd > $12 = 2800 > (kgdb) p avail > $13 = 2018 > (kgdb) p tp->snd_nxt - tp->snd_una > $16 = 2018 > (kgdb) p so->so_snd.sb_acc > $17 = 2018 > (kgdb) p *tp->snd_holes.tqh_first > $22 = {start = 2473784319, end = 2473784358, rxmit = 2473784319, scblink = > {tqe_next = 0x0, tqe_prev = 0xfffff814a6f96350}} > > Apparently tcp_output() has sent more than one segment. I don't know if > this old assertion is correct, but looks like it started to trigger. > > Could this be related to 440f4ba18e3a? > > -- > Gleb Smirnoff > -- Best Regards, Cheng Cui [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div>On Sun, Oct 27, 2024 at 1:14 PM Scheffenegger, Richard <<a href="mailto:Richard.Scheffenegger@netapp.com" target="_blank">Richard.Scheffenegger@netapp.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><br> It's possible; <br> <br> D43355 and D43470 were quite strongly interrelated if my memory serves - any currently only the former is committed.<br><br></blockquote>OK. I give D43470 a green light for now, based on my initial test result <a href="https://wiki.freebsd.org/chengcui/testD43470" target="_blank">https://wiki.freebsd.org/chengcui/testD43470</a>.</div><div class="gmail_quote"><div>Any bugs found shall be fixed after these two. 😉</div><div><br></div><div>cc </div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"> -----Original Message-----<br> From: Gleb Smirnoff <<a href="mailto:glebius@freebsd.org" target="_blank">glebius@freebsd.org</a>> <br> Sent: Sonntag, 27. Oktober 2024 17:39<br> To: <a href="mailto:rscheff@freebsd.org" target="_blank">rscheff@freebsd.org</a>; <a href="mailto:tuexen@freebsd.org" target="_blank">tuexen@freebsd.org</a><br> Cc: <a href="mailto:current@freebsd.org" target="_blank">current@freebsd.org</a><br> Subject: panic: tcp_do_segment: sent too much<br> <br> EXTERNAL EMAIL - USE CAUTION when clicking links or attachments<br> <br> <br> <br> <br> Hi,<br> <br> I just got this panic on my desktop running latest stabweek snapshot.<br> <br> panic: tcp_do_segment: sent too much<br> db_trace_self_wrapper() at db_trace_self_wrapper+0x2c/frame 0xfffffe0209deb440<br> kdb_backtrace() at kdb_backtrace+0x46/frame 0xfffffe0209deb4f0<br> vpanic() at vpanic+0x23d/frame 0xfffffe0209deb630<br> panic() at panic+0x4e/frame 0xfffffe0209deb690<br> tcp_do_segment() at tcp_do_segment+0x3a6c/frame 0xfffffe0209deb8d0<br> tcp_input_with_port() at tcp_input_with_port+0x15db/frame 0xfffffe0209deba60<br> tcp_input() at tcp_input+0x27/frame 0xfffffe0209deba90<br> ip_input() at ip_input+0x1131/frame 0xfffffe0209debb00<br> netisr_dispatch_src() at netisr_dispatch_src+0x18c/frame 0xfffffe0209debb70<br> netisr_dispatch() at netisr_dispatch+0x21/frame 0xfffffe0209debb90<br> ether_demux() at ether_demux+0x2a5/frame 0xfffffe0209debbd0<br> ether_input_internal() at ether_input_internal+0x613/frame 0xfffffe0209debc10<br> ether_nh_input() at ether_nh_input+0xb1/frame 0xfffffe0209debc30<br> netisr_dispatch_src() at netisr_dispatch_src+0x18c/frame 0xfffffe0209debca0<br> netisr_dispatch() at netisr_dispatch+0x21/frame 0xfffffe0209debcc0<br> ether_input() at ether_input+0x16c/frame 0xfffffe0209debd10<br> <br> My kernel is compiled with -O0, which alleviates debugging:<br> <br> (kgdb) frame 4<br> #4 0xffffffff80ea6c3c in tcp_do_segment (tp=0xfffff814a6f96000, m=0xfffff8044d546a00, th=0xfffff8044d546a82, drop_hdrlen=64, tlen=0,<br> iptos=72 'H') at /usr/src/FreeBSD/sys/netinet/tcp_input.c:2812<br> 2812 KASSERT((tp->t_dupacks == 2 &&<br> (kgdb) p tp->t_dupacks<br> $1 = 1<br> (kgdb) p tp->snd_limited<br> $2 = 0 '\000'<br> (kgdb) p/x tp->t_flags<br> $4 = 0x110003e4<br> (kgdb) p/x tp->t_flags & 0x00000010 # TF_SENTFIN<br> $5 = 0x0<br> (kgdb) p tp->t_flags & 1 # TF_ACKNOW<br> $15 = 0<br> (kgdb) p sent<br> $6 = 1507<br> (kgdb) p maxseg<br> $7 = 1400<br> (kgdb) p oldcwnd<br> $8 = 1400<br> (kgdb) p oldsndmax<br> $9 = 2473784830<br> (kgdb) p tp->snd_max<br> $10 = 2473786337<br> (kgdb) p 2473786337 - 2473784830<br> $11 = 1507<br> (kgdb) p tp->snd_cwnd<br> $12 = 2800<br> (kgdb) p avail<br> $13 = 2018<br> (kgdb) p tp->snd_nxt - tp->snd_una<br> $16 = 2018<br> (kgdb) p so->so_snd.sb_acc<br> $17 = 2018<br> (kgdb) p *tp->snd_holes.tqh_first<br> $22 = {start = 2473784319, end = 2473784358, rxmit = 2473784319, scblink = {tqe_next = 0x0, tqe_prev = 0xfffff814a6f96350}}<br> <br> Apparently tcp_output() has sent more than one segment. I don't know if this old assertion is correct, but looks like it started to trigger.<br> <br> Could this be related to 440f4ba18e3a?<br> <br> --<br> Gleb Smirnoff<br> </blockquote></div><br clear="all"><div><br></div><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div></div>Best Regards,<div>Cheng Cui</div></div></div></div> </div> </div> </div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGaXuiJTwKRNNW3UFHnLyLpqTc8FyAEJ%2Bc3TUEOq64p4GbBNLQ>