Date: Mon, 26 May 2003 14:24:01 -0700 (PDT) From: "Justin T. Gibbs" <gibbs@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/aic7xxx aic7xxx.c aic7xxx.h aic7xxx.reg aic7xxx.seq aic7xxx_inline.h Message-ID: <200305262124.h4QLO1sL016769@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
gibbs 2003/05/26 14:24:01 PDT
FreeBSD src repository
Modified files:
sys/dev/aic7xxx aic7xxx.c aic7xxx.h aic7xxx.reg
aic7xxx.seq aic7xxx_inline.h
Log:
Correct/Simplify ignore wide residue message handling
aic7xxx.c:
In ahc_handle_ign_wide_residue():
o Use SCB_XFERLEN_ODD SCB field to determine transfer
"oddness" rather than the DATA_COUNT_ODD logic.
SCB_XFERLEN_ODD is toggled on every ignore wide
residue message so that multiple ignore wide residue
messages for the same transaction are properly supported.
o If the sg list has been exausted, the sequencer
doesn't bother to update the residual data count
since it is known to be zero. Perform the zeroing
manually before calculating the remaining data count.
o Ensure that SG_LIST_NULL is cleared in the
residual sg pointer for "mid-transfer" ignore
wide residue cases.
o Use multibyte in/out macros instead of shifting/masking
by hand.
aic7xxx.h:
Modify the SCB_GET_LUN() macro to mask the lun hardware
SCB field with LID. This leaves two bits in the LUN
field that can be used for other purposes.
aic7xxx.reg:
Change LID to be 0x3F. This is the maximum supported
lun size for non-packetized SCSI. Map the top bit
of the lun to SCB_XFERLEN_ODD. The host must set
this bit whenever a transfer is an odd length.
Remove the ODD_SEG bit field that was used to carry the odd
transfer length information through the SG cache. This
is obviated by SCB_XFERLEN_ODD field.
Remove the DATA_COUNT_ODD scratch ram byte that was used
dynamicaly compute data transfer oddness. This is obviated
by SCB_XFERLEN_ODD field.
aic7xxx.seq:
Be more careful in our handling of the SCB_LUN field. It
must be masked with LID if only lun information is desired.
Remove all updates to the DATA_COUNT_ODD scratch ram field.
Remove all uses of ODD_SEG. These two save quite a few
sequencer instructions.
Use SCB_XFERLEN_ODD to validate the end of transfer
ignore wide residue message case.
aic7xxx_inline.h:
In ahc_queue_scb(), setup the SCB_XFERLEN_ODD field.
Approved by: RE
Revision Changes Path
1.91 +28 -28 src/sys/dev/aic7xxx/aic7xxx.c
1.47 +2 -2 src/sys/dev/aic7xxx/aic7xxx.h
1.45 +3 -12 src/sys/dev/aic7xxx/aic7xxx.reg
1.124 +11 -23 src/sys/dev/aic7xxx/aic7xxx.seq
1.22 +8 -1 src/sys/dev/aic7xxx/aic7xxx_inline.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200305262124.h4QLO1sL016769>