Date: Tue, 20 Oct 2015 03:27:59 +0000 (UTC) From: Ian Lepore <ian@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r289619 - head/sys/arm/arm Message-ID: <201510200327.t9K3RxWQ058756@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ian Date: Tue Oct 20 03:27:59 2015 New Revision: 289619 URL: https://svnweb.freebsd.org/changeset/base/289619 Log: Follow the advice of the misplaced comment and don't access the map struct after freeing it. Remove the comment whose uselessness has been revealed. Modified: head/sys/arm/arm/busdma_machdep.c Modified: head/sys/arm/arm/busdma_machdep.c ============================================================================== --- head/sys/arm/arm/busdma_machdep.c Tue Oct 20 03:25:17 2015 (r289618) +++ head/sys/arm/arm/busdma_machdep.c Tue Oct 20 03:27:59 2015 (r289619) @@ -786,10 +786,9 @@ bus_dmamem_free(bus_dma_tag_t dmat, void ba = coherent_allocator; else ba = standard_allocator; - uma_zfree(dmamap_zone, map); free(map->slist, M_DEVBUF); - /* Be careful not to access map from here on. */ + uma_zfree(dmamap_zone, map); bufzone = busdma_bufalloc_findzone(ba, dmat->maxsize);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201510200327.t9K3RxWQ058756>