Date: Mon, 12 Apr 2021 10:40:10 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Kristof Provost <kp@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 0dd13c77432a - main - libnv: Build PIC Message-ID: <20210412144010.lcv7swa5ob3eql6m@mutt-hbsd> In-Reply-To: <98C59789-AF1F-4B88-B814-F0BD359A06BD@FreeBSD.org> References: <202104100916.13A9GMOp069019@gitrepo.freebsd.org> <20210410152754.4isx26qyvz6k3qbo@mutt-hbsd> <98C59789-AF1F-4B88-B814-F0BD359A06BD@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--og47aeiobytpupsd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 12, 2021 at 01:39:50PM +0200, Kristof Provost wrote: > On 10 Apr 2021, at 17:27, Shawn Webb wrote: > > On Sat, Apr 10, 2021 at 09:16:22AM +0000, Kristof Provost wrote: > > > The branch main has been updated by kp: > > >=20 > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D0dd13c77432ade1ae94c96= 61cbad5537e3e6ab1d > > >=20 > > > commit 0dd13c77432ade1ae94c9661cbad5537e3e6ab1d > > > Author: Kristof Provost <kp@FreeBSD.org> > > > AuthorDate: 2021-04-02 15:06:02 +0000 > > > Commit: Kristof Provost <kp@FreeBSD.org> > > > CommitDate: 2021-04-10 09:16:01 +0000 > > >=20 > > > libnv: Build PIC > > >=20 > > > Build libnv as position independent code so we can use it from > > > shared > > > libraries. > > >=20 > > > MFC after: 4 weeks > > > Sponsored by: Rubicon Communications, LLC ("Netgate") > > > Differential Revision: https://reviews.freebsd.org/D29561 > > > --- > > > lib/libnv/Makefile | 1 + > > > 1 file changed, 1 insertion(+) > > >=20 > > > diff --git a/lib/libnv/Makefile b/lib/libnv/Makefile > > > index b13758931c4e..854cd2c7f3f3 100644 > > > --- a/lib/libnv/Makefile > > > +++ b/lib/libnv/Makefile > > > @@ -10,6 +10,7 @@ SHLIB_MAJOR=3D 0 > > >=20 > > > .PATH: ${SRCTOP}/sys/contrib/libnv ${SRCTOP}/sys/sys > > > CFLAGS+=3D-I${.CURDIR} > > > +CFLAGS+=3D-fPIC > >=20 > > Wouldn't the better fix be renaming LIB to SHLIB like every other PIC > > lib? > >=20 > Ed pointed me at INSTALL_PIC_ARCHIVE. I=E2=80=99m also pondering just mak= ing > libpfctl a .so, which should also fix the issue this addresses. >=20 > The complication is that libpfctl is currently a .a, and can be used in a > shared library itself (for bsnmp), so it has to be - and use - PIC. Out of curiosity, is there a reason not to have the shared library depend on libnv as a shared library? Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --og47aeiobytpupsd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmB0W8gACgkQ/y5nonf4 4fp6fRAAmKuDEACIDiwZBulIBiSRtEJaXkXl53gmferwb+XV+rLGXzCP1W1hB3tD 7ZeFhs6Egvc83FDvDsk9JT4MYr6OKyLa7J31sDCY4hSGWXNxtBYJQnnlVjcSKvrp noWeP75dZ9NM+X0+GlxuE8NVOxPbLqrHmFo0iKMG0GqWo/R41vwytqvkUgP7jMPs lnK60Wk7iJJX8mI6I7DUqwN54D9468Kr6Or89hPVRZ37tZpTbaGKvy/KTCoxZImw /AgfG58dp8FylwxbfhY3TO6qc3cMu8OeMQ0l8rX+TK2nj7nvmhq4Pl2L6021xW+I IoHkj1Mk5fgFatFhZm7JNdvWf1XC9bHRNXMHsRFeiMi6LLwMJA+SL96lO7J3Ptty 910SJ1b+thh2Toaq+s1prbf19GJliHH7iCuvyCgvjoAIHHhCIyZy45SkztStY52r EhTAosfXMdruV57AKZypsAXm6Tkl52U6bsYJMmIkGmIWGKb731dalWz0nyeSS28M LLnvNbeR91tzHOgdfSywBqnaaGpHiZPYQBBMkmxnxIPtst0nKIezxA/zg2AZy5MO pfR1PpDQU+LC4i7VjHdjlLTWa5CuNdtQVkc6GTe0QrUtINtEGm2mBsqlKMg5p8pd t58l2bYUj5feJJ6jiktgvabTZVu/lkXBAHISawOFrNi/A9a6Tqg= =ddtq -----END PGP SIGNATURE----- --og47aeiobytpupsd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210412144010.lcv7swa5ob3eql6m>