Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 21 Aug 2025 07:02:50 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        Toomas Soome <tsoome@me.com>
Cc:        A FreeBSD User <freebsd@walstatt-de.de>,  "Simon J. Gerraty" <sjg@FreeBSD.org>,  "src-committers@freebsd.org" <src-committers@FreeBSD.org>,  "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>,  "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Subject:   Re: git: b44cc1b479fe - main - loader: do not try to open  directories with TFTP
Message-ID:  <pr80008p-o76s-7657-702n-09n06554r7q9@SerrOFQ.bet>
In-Reply-To: <9EEDE524-1ED3-4F41-9584-460DCBF61D81@me.com>
References:  <202508202248.57KMmcTO016280@gitrepo.freebsd.org> <20250821060752.001c9599@thor.sb211.local> <8006s3o4-3nns-509q-n89q-oq88r8o09sn8@SerrOFQ.bet> <9EEDE524-1ED3-4F41-9584-460DCBF61D81@me.com>

next in thread | previous in thread | raw e-mail | index | archive | help
  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--1098556516-1251459429-1755759770=:4606
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8BIT

On Thu, 21 Aug 2025, Toomas Soome wrote:

>> shot in the dark (haven't checked that LOADER_NET_SUPPORT would be defined for these files):
>
>
> I do not think it is the approach you want to take there, because this means you would need to build all those variants to build different components…
>
> I would think of having weak is_tftp() implementation returning false for case the dev_net.c is not built or move dev_net.c into libsa. I’m not quite sure why dev_net.c is outside libsa anyhow;)

Even just moving is_tftp into stand.h would work.

-- 
Bjoern A. Zeeb                                                     r15:7
--1098556516-1251459429-1755759770=:4606--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?pr80008p-o76s-7657-702n-09n06554r7q9>