Skip site navigation (1)Skip section navigation (2) 
Date:      Fri, 27 Nov 2015 16:21:14 +0000 (UTC)
From:      Andrew Rybchenko <arybchik@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r291397 - head/sys/dev/sfxge/common
Message-ID:  <201511271621.tARGLEEh084898@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: arybchik
Date: Fri Nov 27 16:21:14 2015
New Revision: 291397
URL: https://svnweb.freebsd.org/changeset/base/291397

Log:
  sfxge: cleanup: fix prefast annotations on mac stats updates
  
  Submitted by:   Andy Moreton <amoreton at solarflare.com>
  Sponsored by:   Solarflare Communications, Inc.
  MFC after:      2 days

Modified:
  head/sys/dev/sfxge/common/efx.h
  head/sys/dev/sfxge/common/efx_mac.c
  head/sys/dev/sfxge/common/hunt_impl.h
  head/sys/dev/sfxge/common/hunt_mac.c
  head/sys/dev/sfxge/common/siena_impl.h
  head/sys/dev/sfxge/common/siena_mac.c

Modified: head/sys/dev/sfxge/common/efx.h
==============================================================================
--- head/sys/dev/sfxge/common/efx.h	Fri Nov 27 16:18:59 2015	(r291396)
+++ head/sys/dev/sfxge/common/efx.h	Fri Nov 27 16:21:14 2015	(r291397)
@@ -553,7 +553,7 @@ efx_mac_stats_update(
 	__in				efx_nic_t *enp,
 	__in				efsys_mem_t *esmp,
 	__inout_ecount(EFX_MAC_NSTATS)	efsys_stat_t *stat,
-	__out_opt			uint32_t *generationp);
+	__inout_opt			uint32_t *generationp);
 
 #endif	/* EFSYS_OPT_MAC_STATS */
 

Modified: head/sys/dev/sfxge/common/efx_mac.c
==============================================================================
--- head/sys/dev/sfxge/common/efx_mac.c	Fri Nov 27 16:18:59 2015	(r291396)
+++ head/sys/dev/sfxge/common/efx_mac.c	Fri Nov 27 16:21:14 2015	(r291397)
@@ -804,7 +804,7 @@ efx_mac_stats_update(
 	__in				efx_nic_t *enp,
 	__in				efsys_mem_t *esmp,
 	__inout_ecount(EFX_MAC_NSTATS)	efsys_stat_t *essp,
-	__out_opt			uint32_t *generationp)
+	__inout_opt			uint32_t *generationp)
 {
 	efx_port_t *epp = &(enp->en_port);
 	efx_mac_ops_t *emop = epp->ep_emop;

Modified: head/sys/dev/sfxge/common/hunt_impl.h
==============================================================================
--- head/sys/dev/sfxge/common/hunt_impl.h	Fri Nov 27 16:18:59 2015	(r291396)
+++ head/sys/dev/sfxge/common/hunt_impl.h	Fri Nov 27 16:21:14 2015	(r291397)
@@ -237,7 +237,7 @@ hunt_mac_stats_update(
 	__in				efx_nic_t *enp,
 	__in				efsys_mem_t *esmp,
 	__inout_ecount(EFX_MAC_NSTATS)	efsys_stat_t *stat,
-	__out_opt			uint32_t *generationp);
+	__inout_opt			uint32_t *generationp);
 
 #endif	/* EFSYS_OPT_MAC_STATS */
 

Modified: head/sys/dev/sfxge/common/hunt_mac.c
==============================================================================
--- head/sys/dev/sfxge/common/hunt_mac.c	Fri Nov 27 16:18:59 2015	(r291396)
+++ head/sys/dev/sfxge/common/hunt_mac.c	Fri Nov 27 16:21:14 2015	(r291397)
@@ -372,7 +372,7 @@ hunt_mac_stats_update(
 	__in				efx_nic_t *enp,
 	__in				efsys_mem_t *esmp,
 	__inout_ecount(EFX_MAC_NSTATS)	efsys_stat_t *stat,
-	__out_opt			uint32_t *generationp)
+	__inout_opt			uint32_t *generationp)
 {
 	efx_qword_t value;
 	efx_qword_t generation_start;

Modified: head/sys/dev/sfxge/common/siena_impl.h
==============================================================================
--- head/sys/dev/sfxge/common/siena_impl.h	Fri Nov 27 16:18:59 2015	(r291396)
+++ head/sys/dev/sfxge/common/siena_impl.h	Fri Nov 27 16:21:14 2015	(r291397)
@@ -473,7 +473,7 @@ siena_mac_stats_update(
 	__in				efx_nic_t *enp,
 	__in				efsys_mem_t *esmp,
 	__inout_ecount(EFX_MAC_NSTATS)	efsys_stat_t *stat,
-	__out_opt			uint32_t *generationp);
+	__inout_opt			uint32_t *generationp);
 
 #endif	/* EFSYS_OPT_MAC_STATS */
 

Modified: head/sys/dev/sfxge/common/siena_mac.c
==============================================================================
--- head/sys/dev/sfxge/common/siena_mac.c	Fri Nov 27 16:18:59 2015	(r291396)
+++ head/sys/dev/sfxge/common/siena_mac.c	Fri Nov 27 16:21:14 2015	(r291397)
@@ -235,7 +235,7 @@ siena_mac_stats_update(
 	__in				efx_nic_t *enp,
 	__in				efsys_mem_t *esmp,
 	__inout_ecount(EFX_MAC_NSTATS)	efsys_stat_t *stat,
-	__out_opt			uint32_t *generationp)
+	__inout_opt			uint32_t *generationp)
 {
 	efx_qword_t value;
 	efx_qword_t generation_start;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201511271621.tARGLEEh084898>