Date: Thu, 29 Jul 2021 23:14:25 GMT From: Kirk McKusick <mckusick@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 412b5e40a721 - main - Diagnotic improvement to soft dependency structure management. Message-ID: <202107292314.16TNEPsc036933@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by mckusick: URL: https://cgit.FreeBSD.org/src/commit/?id=412b5e40a721430adba1b4abae210641f733f976 commit 412b5e40a721430adba1b4abae210641f733f976 Author: Kirk McKusick <mckusick@FreeBSD.org> AuthorDate: 2021-07-29 23:11:58 +0000 Commit: Kirk McKusick <mckusick@FreeBSD.org> CommitDate: 2021-07-29 23:13:54 +0000 Diagnotic improvement to soft dependency structure management. The soft updates diagnotic code keeps a list for each type of soft update dependency. When a new block is allocated for a file it is initially tracked by a "newblk" dependency. The "newblk" dependency eventually becomes either an "allocdirect" dependency or an "indiralloc" dependency. The diagnotic code failed to move the "newblk" from the list of "newblk"s to its new type list. No functional change intended. Reviewed by: Chuck Silvers (as part of a larger change) Tested by: Peter Holm (as part of a larger change) Sponsored by: Netflix --- sys/ufs/ffs/ffs_softdep.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c index 75120175e4a1..da80f28bc814 100644 --- a/sys/ufs/ffs/ffs_softdep.c +++ b/sys/ufs/ffs/ffs_softdep.c @@ -1293,6 +1293,10 @@ workitem_reassign(item, newtype) dep_total[newtype]++; FREE_GBLLOCK(&lk); item->wk_type = newtype; +#ifdef INVARIANTS + LIST_REMOVE(item, wk_all); + LIST_INSERT_HEAD(&ump->softdep_alldeps[newtype], item, wk_all); +#endif } /*
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202107292314.16TNEPsc036933>