Date: Sat, 27 Jun 2020 21:26:31 -0500 From: Kyle Evans <kevans@freebsd.org> To: Mateusz Piotrowski <0mp@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r362710 - stable/11/usr.bin/sed/tests Message-ID: <CACNAnaFwuT2%2BYxH%2BRBh71-gO51b8HeFEkgFkHZvDsz0CvV7Nsg@mail.gmail.com> In-Reply-To: <1c896bbe-7a85-bc76-5163-cf83a0c39b8e@FreeBSD.org> References: <202006272251.05RMpGxH086999@repo.freebsd.org> <CACNAnaEayuRWV2hxFu3uZV7s2D_DHTgoEaotJTLuaHAbDJLUVA@mail.gmail.com> <1c896bbe-7a85-bc76-5163-cf83a0c39b8e@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 27, 2020 at 6:32 PM Mateusz Piotrowski <0mp@freebsd.org> wrote: > > On 6/28/20 1:28 AM, Kyle Evans wrote: > > (sorry, still on mobile) > > Please restore escape_subst...as per my last email, it was only hex_subst that needed to go away. The former was already there. > > On Sat, Jun 27, 2020, 17:51 Mateusz Piotrowski <0mp@freebsd.org> wrote: >> >> Author: 0mp (doc,ports committer) >> Date: Sat Jun 27 22:51:15 2020 >> New Revision: 362710 >> URL: https://svnweb.freebsd.org/changeset/base/362710 >> >> Log: >> Disable mismerged tests committed in r362687 >> >> Reported by: lwhsu >> >> Modified: >> stable/11/usr.bin/sed/tests/sed2_test.sh >> >> Modified: stable/11/usr.bin/sed/tests/sed2_test.sh >> ============================================================================== >> --- stable/11/usr.bin/sed/tests/sed2_test.sh Sat Jun 27 21:37:48 2020 (r362709) >> +++ stable/11/usr.bin/sed/tests/sed2_test.sh Sat Jun 27 22:51:15 2020 (r362710) >> @@ -92,7 +92,5 @@ atf_init_test_cases() >> atf_add_test_case inplace_command_q >> atf_add_test_case inplace_hardlink_src >> atf_add_test_case inplace_symlink_src >> - atf_add_test_case escape_subst >> atf_add_test_case commands_on_stdin >> - atf_add_test_case hex_subst >> } > > I've tested the change and atf_add_test_case escape_subst was also failing... > > Would you like me to bring back escape_subst? Back at a machine, I see now that I looked at the wrong commit and apparently did infact not merge \r, \n, and \t back, so this was my bad -- these tests are now as they should be as of this commit, sorry about that. Thanks! Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaFwuT2%2BYxH%2BRBh71-gO51b8HeFEkgFkHZvDsz0CvV7Nsg>