Date: Tue, 20 Oct 2015 11:51:47 -0700 From: Navdeep Parhar <nparhar@gmail.com> To: Hans Petter Selasky <hps@selasky.org>, John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r289633 - head/sys/ofed/include/linux Message-ID: <56268D43.6000209@gmail.com> In-Reply-To: <56268A5A.70103@selasky.org> References: <201510201602.t9KG2BeA079785@repo.freebsd.org> <1878746.bHLk1ML9QM@ralph.baldwin.cx> <56268A5A.70103@selasky.org>
index | next in thread | previous in thread | raw e-mail
On 10/20/2015 11:39, Hans Petter Selasky wrote: > Hi, > > On 10/20/15 20:04, John Baldwin wrote: >> On Tuesday, October 20, 2015 04:02:11 PM Hans Petter Selasky wrote: >>> Author: hselasky >>> Date: Tue Oct 20 16:02:11 2015 >>> New Revision: 289633 >>> URL: https://svnweb.freebsd.org/changeset/base/289633 >>> >>> Log: >>> Add missing FreeBSD RCS keyword and SVN properties. >>> >>> Sponsored by: Mellanox Technologies >>> >>> Modified: >>> head/sys/ofed/include/linux/io-mapping.h (contents, props changed) >>> head/sys/ofed/include/linux/io.h (contents, props changed) >>> head/sys/ofed/include/linux/jhash.h (contents, props changed) >>> head/sys/ofed/include/linux/linux_compat.c (contents, props >>> changed) >>> head/sys/ofed/include/linux/linux_idr.c (contents, props changed) >>> head/sys/ofed/include/linux/linux_radix.c (contents, props changed) >>> head/sys/ofed/include/linux/vmalloc.h (contents, props changed) >>> >>> Modified: head/sys/ofed/include/linux/io-mapping.h >>> ============================================================================== >>> >>> --- head/sys/ofed/include/linux/io-mapping.h Tue Oct 20 15:28:02 >>> 2015 (r289632) >>> +++ head/sys/ofed/include/linux/io-mapping.h Tue Oct 20 16:02:11 >>> 2015 (r289633) >>> @@ -1,3 +1,4 @@ >>> +/* $FreeBSD$ */ >>> /*- >>> * Copyright (c) 2010 Isilon Systems, Inc. >>> * Copyright (c) 2010 iX Systems, Inc. >> >> Just a note on style. Most headers put the tag below the license >> block like so >> from <sys/bus.h>: > > I'll fix that. > >> >> /*- >> * Copyright (c) 1997,1998,2003 Doug Rabson >> * All rights reserved. >> * >> ... >> >> * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE >> POSSIBILITY OF >> * SUCH DAMAGE. >> * >> * $FreeBSD: head/sys/sys/bus.h 284088 2015-06-06 17:25:45Z marcel $ >> */ >> >> It would have been nice to be more consistent with the rest of the >> tree. Maybe >> look around next time to see if there is an existing style? >> >>> Modified: head/sys/ofed/include/linux/jhash.h >>> ============================================================================== >>> >>> --- head/sys/ofed/include/linux/jhash.h Tue Oct 20 15:28:02 >>> 2015 (r289632) >>> +++ head/sys/ofed/include/linux/jhash.h Tue Oct 20 16:02:11 >>> 2015 (r289633) >>> @@ -18,6 +18,7 @@ >>> * >>> * I've modified Bob's hash to be useful in the Linux kernel, and >>> * any bugs present are surely my fault. -DaveM >>> + * $FreeBSD$ >>> */ >> >> Please fix this one to leave a blank line before the tag at least. >> > > I tried to make linux/jhash.h similar to dev/cxgb/common/jhash.h, which > are actually duplicate files. cxgb's copy of jhash.h does have a blank line before the $FreeBSD$ tag. These days jenkins_hash is available in the kernel (see hash(9)) so there's no real need for cxgb to include this file, but I don't touch cxgb except for bug fixes. cxgbe (with the 'e') uses FNV hash from the kernel and so it doesn't have any duplicate hashing implementation. Regards, Navdeephome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56268D43.6000209>