Date: Wed, 20 Feb 2013 02:58:57 GMT From: Marcelo Araujo <araujo@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/176277: [kernel] On net/if_var.h we can't return a value in a void function. Message-ID: <201302200258.r1K2wvNP038154@red.freebsd.org> Resent-Message-ID: <201302200300.r1K300fY054659@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 176277
>Category: kern
>Synopsis: [kernel] On net/if_var.h we can't return a value in a void function.
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Feb 20 03:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Marcelo Araujo
>Release: 9.1-RELEASE
>Organization:
FreeBSD
>Environment:
FreeBSD qnap91 9.1-RELEASE FreeBSD 9.1-RELEASE #0: Tue Jan 22 11:03:23 CST 2013 root@qnap91:/usr/obj/usr/src/sys/QNAP amd64
>Description:
On FreeBSD-HEAD specifically on sys/net/if_var.h at line 695 on the function drbr_advance we cannot call a return in a void function, we should use the mbuf struct.
>How-To-Repeat:
Build it using clang.
>Fix:
Patch attached with submission follows:
--- sys/net/if_var.h 2013-02-19 10:54:20.065079344 +0800
+++ /tmp/a 2013-02-20 10:51:38.878262871 +0800
@@ -695,7 +695,7 @@
return (buf_ring_dequeue_sc(br));
}
-static __inline void
+static __inline struct mbuf *
drbr_advance(struct ifnet *ifp, struct buf_ring *br)
{
#ifdef ALTQ
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302200258.r1K2wvNP038154>