Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 01 Sep 2019 12:32:34 -0700
From:      Cy Schubert <Cy.Schubert@cschubert.com>
To:        Ed Maste <emaste@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r351659 - in head: contrib/libc++/include  contrib/netbsd-tests/lib/libc/ssp gnu/lib/libssp include lib/libc/stdio
Message-ID:  <201909011932.x81JWYts004074@slippy.cwsent.com>
In-Reply-To: <201909011612.x81GC5DW097846@repo.freebsd.org>
References:  <201909011612.x81GC5DW097846@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <201909011612.x81GC5DW097846@repo.freebsd.org>, Ed Maste writes:
> Author: emaste
> Date: Sun Sep  1 16:12:05 2019
> New Revision: 351659
> URL: https://svnweb.freebsd.org/changeset/base/351659
>
> Log:
>   libc: remove gets
>   
>   gets is unsafe and shouldn't be used (for many years now).  Leave it in
>   the existing symbol version so anything that previously linked aginst it
>   still runs, but do not allow new software to link against it.
>   
>   (The compatability/legacy implementation must not be static so that
>   the symbol and in particular the compat sym gets@FBSD_1.0 make it
>   into libc.)
>   
>   PR:		222796 (exp-run)
>   Reported by:	Paul Vixie
>   Reviewed by:	allanjude, cy, eadler, gnn, jhb, kib, ngie (some earlie
> r)
>   Relnotes:	Yes
>   Sponsored by:	The FreeBSD Foundation
>   Differential Revision:	https://reviews.freebsd.org/D12298
>
> Modified:
>   head/contrib/libc++/include/cstdio
>   head/contrib/netbsd-tests/lib/libc/ssp/h_gets.c
>   head/gnu/lib/libssp/Makefile
>   head/include/stdio.h
>   head/lib/libc/stdio/fgets.3
>   head/lib/libc/stdio/gets.c
>   head/lib/libc/stdio/stdio.3

Should we encourage the use of gets_s() in the man page or in other doc?

This probably requires a __FreeBSD_version bump.


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201909011932.x81JWYts004074>