Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Feb 2021 15:50:14 GMT
From:      Allan Jude <allanjude@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 8c280db0b4d2 - main - ipmi_ssif: Fix inverted for the end of multi-part reads
Message-ID:  <202102181550.11IFoEQu066677@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by allanjude:

URL: https://cgit.FreeBSD.org/src/commit/?id=8c280db0b4d22ad92152bf05f941201428c80b87

commit 8c280db0b4d22ad92152bf05f941201428c80b87
Author:     Allan Jude <allanjude@FreeBSD.org>
AuthorDate: 2021-02-18 15:48:01 +0000
Commit:     Allan Jude <allanjude@FreeBSD.org>
CommitDate: 2021-02-18 15:48:01 +0000

    ipmi_ssif: Fix inverted for the end of multi-part reads
    
    As per Intelligent Platform Management Interface Specification v2.0 rev. 1.1,
    section 12.5: SSIF Multi-part Read Transactions
    
    Sponsored by:   Ampere Computing LLC
    Submitted by:   Klara Inc.
    Reviewed by:    manu
    Differential Revision:  https://reviews.freebsd.org/D28749
---
 sys/dev/ipmi/ipmi_ssif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/ipmi/ipmi_ssif.c b/sys/dev/ipmi/ipmi_ssif.c
index 197c317dcc09..e761cfdeb081 100644
--- a/sys/dev/ipmi/ipmi_ssif.c
+++ b/sys/dev/ipmi/ipmi_ssif.c
@@ -297,7 +297,7 @@ read_start:
 		len += count - 1;
 
 		/* If this was the last block we are done. */
-		if (ssif_buf[0] != 0xff)
+		if (ssif_buf[0] == 0xff)
 			break;
 		block++;
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202102181550.11IFoEQu066677>