Date: Thu, 11 Aug 2016 17:53:41 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r303963 - head/sys/powerpc/include Message-ID: <alpine.BSF.2.00.1608111751270.4366@ai.fobar.qr> In-Reply-To: <1743387.a2iKJ8FVcJ@ralph.baldwin.cx> References: <201608111506.u7BF6DX4046653@repo.freebsd.org> <1743387.a2iKJ8FVcJ@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 11 Aug 2016, John Baldwin wrote: > On Thursday, August 11, 2016 03:06:13 PM Bjoern A. Zeeb wrote: >> Author: bz >> Date: Thu Aug 11 15:06:12 2016 >> New Revision: 303963 >> URL: https://svnweb.freebsd.org/changeset/base/303963 >> >> Log: >> Revert r303890 for now here as camdd fails to build on powerpc* >> due to device_t only being available under _KERNEL. >> >> Reported by: bde (_KERNEL in general), kib (build failure) >> MFC after: 1 day >> X-MFC with: r303890 > > I think the real issue though is exposting this function prototype to > userland (I looked at it the other day). camdd only wants bus_dma_segment_t. > It also explicitly includes <sys/bus_dma.h> which is a no-no. I think this > should be fixed to either define a suitable bus_dma_segment_t explicitly > in libcam.h or the bus_dma headers have to all be audited to add > appropriate #ifdef _KERNEL guards. Oh yes, I agree with you. Having looked at all places I just decided that my first priority was to get builds unbroken and then leave it to others doing the right thing (tm). camdd also has a couple of strange includes, duplicated includes (given things are implicatly included), yaddah. I won't be in the way of a cleanup unless the builds break again :) -- Bjoern A. Zeeb r15:7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1608111751270.4366>