Date: Sun, 13 Dec 2020 19:57:05 +0100 From: Stefan Esser <se@freebsd.org> To: Yuri Pankov <yuripv@yuripv.dev> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r368606 - head/usr.bin/calendar Message-ID: <3dad51fd-ce00-99e2-e83a-fa4c18e6bfce@freebsd.org> In-Reply-To: <ccdca62f-3566-9469-f6f8-ab03b81c2e4f@yuripv.dev> References: <202012130938.0BD9cpTp041055@repo.freebsd.org> <ccdca62f-3566-9469-f6f8-ab03b81c2e4f@yuripv.dev>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --I04qkHyLSvATaJOyKYAw0dSgjqSDPElBv Content-Type: multipart/mixed; boundary="7Z581B1MjGYPd68vZ9am94BCVLlFBCfqK"; protected-headers="v1" From: Stefan Esser <se@freebsd.org> To: Yuri Pankov <yuripv@yuripv.dev> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <3dad51fd-ce00-99e2-e83a-fa4c18e6bfce@freebsd.org> Subject: Re: svn commit: r368606 - head/usr.bin/calendar References: <202012130938.0BD9cpTp041055@repo.freebsd.org> <ccdca62f-3566-9469-f6f8-ab03b81c2e4f@yuripv.dev> In-Reply-To: <ccdca62f-3566-9469-f6f8-ab03b81c2e4f@yuripv.dev> --7Z581B1MjGYPd68vZ9am94BCVLlFBCfqK Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 13.12.20 um 12:13 schrieb Yuri Pankov: > Stefan E=C3=9Fer wrote: >> Author: se >> Date: Sun Dec 13 09:38:50 2020 >> New Revision: 368606 >> URL: https://svnweb.freebsd.org/changeset/base/368606 >> >> Log: >> =C2=A0=C2=A0 Fix WITHOUT_ICONV build >> =C2=A0=C2=A0 There was an unprotected use of nl_langinfo() to determin= e the=20 >> order of >> =C2=A0=C2=A0 day vs. month in the generated output. >=20 > That's strange, nl_langinfo() is standard and its visibility should not= =20 > (and does not?) depend on WITH/WITHOUT_ICONV.=C2=A0 May be just move=20 > langinfo.h include outside of "#ifdef WITH_ICONV" block? Yes, you are perfectly right ... I had noticed that WITHOUT_ICONV lead to a problem due to the missing=20 prototype, but I had not seen that this was due to the include of langinfo.h being conditional on WITH_ICONV. I'll revert this commit and move the include of langinfo.h out of the conditional block, as suggested by you. Thanks for pointing this out! Best regards, STefan --7Z581B1MjGYPd68vZ9am94BCVLlFBCfqK-- --I04qkHyLSvATaJOyKYAw0dSgjqSDPElBv Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAl/WZAEFAwAAAAAACgkQR+u171r99UR6 MAgAuImw4Y0y+GDlerwKn4/l5GS0rFaipOtmyIP3w/bDQmDoIuB23n7jjfdQQF051BvRi9CWVEof wpngvE6O8LavM9B/WIedi2s9tR9sQyAiPMUTDfnbBgJ+VxBM+WYd0aNNeeJss5i6Itmw8MSg187j TjZl++15uX9wu4EnL5itAiZWqX0rS0+nyxMkFsuW+r7NBubNheA+Zp9+JaZqF3UnH9Q8c8JwDIjf xhcJQzK53F2YBVnUu5GW20044WFp+9lazQJyG3Bb5RmnaKftaO1OUzRnnHOT7TNv+nJ3fMyiAeA/ hGi0UeeA4dE4BkT56ull+gcam4lSJ9T3P1A6iTiNRQ== =oyw3 -----END PGP SIGNATURE----- --I04qkHyLSvATaJOyKYAw0dSgjqSDPElBv--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3dad51fd-ce00-99e2-e83a-fa4c18e6bfce>