Date: Mon, 26 Dec 2011 07:50:16 -0500 From: Justin Hibbits <chmeeedalf@gmail.com> To: Doug Barton <dougb@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, "Bjoern A. Zeeb" <bz@FreeBSD.org>, src-committers@freebsd.org Subject: Re: svn commit: r228874 - head/sys/dev/hwpmc Message-ID: <0AA7AB29-F489-4C8E-BA2A-85DC6788FFC6@gmail.com> In-Reply-To: <4EF812F4.9010902@FreeBSD.org> References: <201112251429.pBPETawV062695@svn.freebsd.org> <4EF812F4.9010902@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 26, 2011, at 1:23 AM, Doug Barton wrote: > On 12/25/2011 06:29, Bjoern A. Zeeb wrote: >> Author: bz >> Date: Sun Dec 25 14:29:36 2011 >> New Revision: 228874 >> URL: http://svn.freebsd.org/changeset/base/228874 >> >> Log: >> Quite the tinderbox for the holidays. Remove the assert[1]. > > Shouldn't "Why it's Ok to remove the assert" be part of this commit > log? When I suggested the removal, I didn't see it as necessary, and was just looking to quiet the build for now while I look closer. Right now, that code is never called, as it's only used when configured for sampling, and that code was originally just a copy from the hwpmc_amd driver. I will be finishing the sampling code in the new year. - Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0AA7AB29-F489-4C8E-BA2A-85DC6788FFC6>