Date: Thu, 5 Apr 2018 18:20:50 -0700 From: Conrad Meyer <cem@freebsd.org> To: Allan Jude <allanjude@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332070 - in head/sys/geom: . label raid Message-ID: <CAG6CVpXjmyZ-gfJh%2BvkzsOQOyu8k5sxL_RgzX4k_pdRPWSuyWA@mail.gmail.com> In-Reply-To: <4cd9a49c-2d75-bfac-20df-72e8c80eded4@freebsd.org> References: <201804051356.w35Duexg022529@repo.freebsd.org> <4cd9a49c-2d75-bfac-20df-72e8c80eded4@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 5, 2018 at 6:08 PM, Allan Jude <allanjude@freebsd.org> wrote: > On 2018-04-05 09:56, Sean Bruno wrote: >> Author: sbruno >> Date: Thu Apr 5 13:56:40 2018 >> New Revision: 332070 >> URL: https://svnweb.freebsd.org/changeset/base/332070 >> >> Log: >> Squash error from geom by sizing ident strings to DISK_IDENT_SIZE. >> >> ... > I might be missing something here, but it seems like you didn't actually > change the side of > ... > struct md_s The md side can be as small as it likes. It's the caller who needs to provide the large buffer, for other providers of the GEOM::ident attribute. > And I don't see where the destination buffer went from 24 bytes to a > larger value. Check the change in md_intel.c. Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpXjmyZ-gfJh%2BvkzsOQOyu8k5sxL_RgzX4k_pdRPWSuyWA>