Date: Thu, 18 Oct 2007 00:21:33 +0200 From: Max Laier <max@love2party.net> To: freebsd-current@freebsd.org Cc: "Victor M. Blood" <freebsd@masm.elcom.ru> Subject: Re: ipfilter cannot be build within because warning's are present Message-ID: <200710180021.39250.max@love2party.net> In-Reply-To: <6210619899.20071018020530@masm.elcom.ru> References: <359284519.20071018014832@masm.elcom.ru> <200710172357.18221.max@love2party.net> <6210619899.20071018020530@masm.elcom.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1749356.CM5bSGe87K Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 18 October 2007, Victor M. Blood wrote: > On 18.10.2007, Max Laier wrote: > > On Wednesday 17 October 2007, Victor M. Blood wrote: > >> Hi, All. > >> > >> I try to use options in kernel instead of a module build of the > >> ipfilter and got error then kernel builds. > >> > >> I'm edit files: fil.c, ip_auth.h, ip_auth.h, ip_log.c ip_compat.h > >> and correct #ifdef statament :) no more warnings... > > > > ipf is likely broken anyway. See thread: "7.0 CURRENT, need help > > with panic: Trying sleep, but thread marked as sleeping prohibited" > > on this ML a few days back. That this warning went unnoticed tells > > you something, too. > > New version, new problems, no more to say) few days back I have panic > with ip filter, now it seems as worked, after upgrade. > > #ipf -V > ipf: IP Filter: v4.1.27 (404) > Kernel: IP Filter: v4.1.27 > Running: yes > Log Flags: 0 =3D none set > Default: block all, Logging: available > Active list: 0 > Feature mask: 0xe Is this with a WITNESS/INVARIANTS enabled kernel? From a quick glance at=20 the code you should see warnings on the ioctl path as there are copy=20 operations to/from userland with the lock held. Moving to rw_locks is the right direction, but the config path is still=20 broken. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart1749356.CM5bSGe87K Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQBHForzXyyEoT62BG0RAjhvAJ94Mzhh5WRlHaFsTjSh0VvbhVTjKQCeNSk6 KI5H3UNeG6IgIBdhGI++tPI= =/JV0 -----END PGP SIGNATURE----- --nextPart1749356.CM5bSGe87K--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710180021.39250.max>