Date: Sun, 06 Apr 2008 09:48:45 -0400 From: Coleman Kane <cokane@FreeBSD.org> To: Greg 'groggy' Lehey <grog@FreeBSD.org> Cc: cvs-src@FreeBSD.org, "Bjoern A. Zeeb" <bz@FreeBSD.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/bin/ls ls.1 ls.c ls.h print.c Message-ID: <47F8D4BD.1020901@FreeBSD.org> In-Reply-To: <20080406053648.GC27705@dereel.lemis.com> References: <200804040357.m343vlQ8083007@repoman.freebsd.org> <20080405193851.J66744@maildrop.int.zabbadoz.net> <20080405234758.GB27705@dereel.lemis.com> <47F81C48.1040103@FreeBSD.org> <20080406053648.GC27705@dereel.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Greg 'groggy' Lehey wrote: > On Saturday, 5 April 2008 at 20:41:44 -0400, Coleman Kane wrote: > >> Greg 'groggy' Lehey wrote: >> >>> On Saturday, 5 April 2008 at 19:40:02 +0000, Bjoern A. Zeeb wrote: >>> >>> >>>> On Fri, 4 Apr 2008, Greg Lehey wrote: >>>> >>>> >>>> >>>>> grog 2008-04-04 03:57:47 UTC >>>>> >>>>> FreeBSD src repository >>>>> >>>>> Modified files: >>>>> bin/ls ls.1 ls.c ls.h print.c >>>>> Log: >>>>> Add -D option to specify exact format of date and time output with ls -l. >>>>> >>>>> >>>> I think something went wrong here. Could you please fix this. Thanks. >>>> >>>> bz@dopt:/local/building/freebsd/HEAD/bin/ls> ll >>>> total 80 >>>> drwxr-xr-x 2 bz wheel 512 Apr 5 15:18 CVS/ >>>> -rw-r--r-- 1 bz wheel 300 May 25 2004 Makefile >>>> -rw-r--r-- 1 bz wheel 4803 Mar 24 2006 cmp.c >>>> -rw-r--r-- 1 bz wheel 2852 Mar 24 2006 extern.h >>>> >>>> >>> Ugh. My editor was a little too zealous in replacing spaces with tabs :-( >>> >> Uhm.... shouldn't this be "\t" instead of the actualy tab character >> (0x08)? >> > > No. It should be two spaces. > > Here's the diff :-) > > --- print.c 4 Apr 2008 03:57:46 -0000 1.77 > +++ print.c 5 Apr 2008 23:44:24 -0000 > @@ -388,7 +388,7 @@ > format = d_first ? "%e %b %R" : "%b %e %R"; > else > /* mmm dd yyyy || dd mmm yyyy */ > - format = d_first ? "%e %b %Y" : "%b %e %Y"; > + format = d_first ? "%e %b %Y" : "%b %e %Y"; > strftime(longstring, sizeof(longstring), format, localtime(&ftime)); > > For reasons lost in the mists of time, there are two spaces before the > %Y in this format, but my editor accidentally replaced them with a tab > character. As you can see, that's not immediately obvious. > > Greg > -- > See complete headers for address and phone numbers. > Oh heh. I had a dyslexic moment there (I read "tabs with spaces"). Nevermind. -- Coleman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47F8D4BD.1020901>